Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2394263004: Reformat comments in core/layout up until LayoutMultiColumnFlowThread (Closed)

Created:
4 years, 2 months ago by eae
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reformat comments in core/layout up until LayoutMultiColumnFlowThread BUG=563793 R=pdr@chromium.org NOTRY=true Committed: https://crrev.com/c71eacb21bfaa2f7fe6580b3e17f57819142ef3e Cr-Commit-Position: refs/heads/master@{#423888}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebase w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1466 lines, -1056 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 7 chunks +26 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 33 chunks +154 lines, -116 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp View 1 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp View 1 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutButton.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutButton.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutCounter.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutCounter.cpp View 13 chunks +82 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 4 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFileUploadControl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFileUploadControl.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.h View 4 chunks +19 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp View 7 chunks +22 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFrame.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp View 11 chunks +51 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp View 3 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.h View 3 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp View 6 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 74 chunks +336 lines, -220 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 7 chunks +22 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 6 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 32 chunks +130 lines, -94 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListBox.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListItem.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListItem.cpp View 5 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 6 chunks +16 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 6 chunks +21 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h View 1 5 chunks +140 lines, -109 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 51 chunks +255 lines, -199 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp View 17 chunks +39 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
eae
4 years, 2 months ago (2016-10-07 01:44:53 UTC) #1
pdr.
LGTM to submit as-is, all comments optional. https://codereview.chromium.org/2394263004/diff/1/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h (right): https://codereview.chromium.org/2394263004/diff/1/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h#newcode158 third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h:158: // (LayoutFlow) ...
4 years, 2 months ago (2016-10-07 02:49:40 UTC) #6
eae
Thanks pdr! https://codereview.chromium.org/2394263004/diff/1/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h (right): https://codereview.chromium.org/2394263004/diff/1/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h#newcode158 third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h:158: // (LayoutFlow) to return the remaining width ...
4 years, 2 months ago (2016-10-07 16:38:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394263004/20001
4 years, 2 months ago (2016-10-07 16:51:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 16:58:53 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 17:02:18 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c71eacb21bfaa2f7fe6580b3e17f57819142ef3e
Cr-Commit-Position: refs/heads/master@{#423888}

Powered by Google App Engine
This is Rietveld 408576698