Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2394263003: Make sure we don't try scrolling a node without a LayoutObject (Closed)

Created:
4 years, 2 months ago by bokan
Modified:
4 years, 2 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, blink-reviews, nzolghadr+blinkwatch_chromium.org, dtapuska+blinkwatch_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure we don't try scrolling a node without a LayoutObject Early out of Blink's scrolling code if there's no LayoutObject to scroll. BUG=653327 Committed: https://crrev.com/41c5c138b099891457c2e0cb965b8f24dacc403e Cr-Commit-Position: refs/heads/master@{#424625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -9 lines) Patch
M third_party/WebKit/Source/core/input/ScrollManager.cpp View 4 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +33 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/web/tests/data/display-none.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
bokan
4 years, 2 months ago (2016-10-06 22:22:30 UTC) #5
bokan
ping
4 years, 2 months ago (2016-10-11 18:35:33 UTC) #8
dtapuska
On 2016/10/11 18:35:33, bokan wrote: > ping lgtm
4 years, 2 months ago (2016-10-11 18:42:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394263003/1
4 years, 2 months ago (2016-10-11 18:51:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/309562)
4 years, 2 months ago (2016-10-11 23:18:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394263003/1
4 years, 2 months ago (2016-10-11 23:46:07 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 01:10:24 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 01:12:43 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41c5c138b099891457c2e0cb965b8f24dacc403e
Cr-Commit-Position: refs/heads/master@{#424625}

Powered by Google App Engine
This is Rietveld 408576698