Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: media/filters/pipeline_integration_test.cc

Issue 239423005: Wire up codec_delay() to MP3StreamParser and FFmpegAudioDecoder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Switch codec_delay() to frames. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/pipeline_integration_test.cc
diff --git a/media/filters/pipeline_integration_test.cc b/media/filters/pipeline_integration_test.cc
index dfea318086ee6dfeda535419e9868989f5fa4add..e287b739d4f3fa0ac2c7017c824c5c8724bff027 100644
--- a/media/filters/pipeline_integration_test.cc
+++ b/media/filters/pipeline_integration_test.cc
@@ -792,7 +792,7 @@ TEST_P(PipelineIntegrationTest, MediaSource_ADTS_TimestampOffset) {
TEST_P(PipelineIntegrationTest, MediaSource_MP3) {
MockMediaSource source("sfx.mp3", kMP3, kAppendWholeFile, GetParam());
- StartPipelineWithMediaSource(&source);
+ StartHashedPipelineWithMediaSource(&source);
source.EndOfStream();
EXPECT_EQ(1u, pipeline_->GetBufferedTimeRanges().size());
@@ -802,6 +802,10 @@ TEST_P(PipelineIntegrationTest, MediaSource_MP3) {
Play();
EXPECT_TRUE(WaitUntilOnEnded());
+
+ // Verify that codec delay was stripped, if it wasn't the hash would be:
+ // "5.20,1.88,8.52,4.60,8.62,2.00,"
+ EXPECT_EQ("6.58,3.21,8.82,3.64,7.12,1.60,", GetAudioHash());
}
TEST_P(PipelineIntegrationTest, MediaSource_MP3_TimestampOffset) {

Powered by Google App Engine
This is Rietveld 408576698