Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: media/filters/pipeline_integration_test.cc

Issue 239423005: Wire up codec_delay() to MP3StreamParser and FFmpegAudioDecoder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ResetTimestampState() on config change. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/opus_audio_decoder.cc ('k') | media/formats/mp4/mp4_stream_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/pipeline_integration_test.cc
diff --git a/media/filters/pipeline_integration_test.cc b/media/filters/pipeline_integration_test.cc
index 133c497db7372f459afb28109d4cde2ebac850d7..b3ff5a5cef3004d5941b3b98befbc84c514f4332 100644
--- a/media/filters/pipeline_integration_test.cc
+++ b/media/filters/pipeline_integration_test.cc
@@ -863,7 +863,7 @@ TEST_P(PipelineIntegrationTest, MediaSource_ADTS_TimestampOffset) {
TEST_P(PipelineIntegrationTest, MediaSource_MP3) {
MockMediaSource source("sfx.mp3", kMP3, kAppendWholeFile, GetParam());
- StartPipelineWithMediaSource(&source);
+ StartHashedPipelineWithMediaSource(&source);
source.EndOfStream();
EXPECT_EQ(1u, pipeline_->GetBufferedTimeRanges().size());
@@ -873,6 +873,10 @@ TEST_P(PipelineIntegrationTest, MediaSource_MP3) {
Play();
EXPECT_TRUE(WaitUntilOnEnded());
+
+ // Verify that codec delay was stripped, if it wasn't the hash would be:
+ // "5.16,1.25,7.78,4.29,8.98,2.76,"
+ EXPECT_EQ("5.81,2.71,8.97,4.32,7.83,1.12,", GetAudioHash());
}
TEST_P(PipelineIntegrationTest, MediaSource_MP3_TimestampOffset) {
« no previous file with comments | « media/filters/opus_audio_decoder.cc ('k') | media/formats/mp4/mp4_stream_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698