Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2394223002: Rename MediaArtwork -> MediaImage (Closed)

Created:
4 years, 2 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, haraken, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename MediaArtwork -> MediaImage We should update the naming for media metadata artwork images from "MediaArtwork" to "MediaImage" to match the spec. Spec URL: https://wicg.github.io/mediasession/#the-mediaimage-interface BUG=616411 Committed: https://crrev.com/107c9084e019c286b8f8f4dbfc3130caa857e85a Cr-Commit-Position: refs/heads/master@{#423999}

Patch Set 1 #

Patch Set 2 : fixed layouttests #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -274 lines) Patch
M content/browser/media/session/media_metadata_sanitizer.cc View 4 chunks +29 lines, -28 lines 0 comments Download
M content/common/media/media_session.typemap View 1 chunk +1 line, -1 line 0 comments Download
M content/common/media/media_session_struct_traits.h View 2 chunks +9 lines, -9 lines 0 comments Download
M content/public/common/media_metadata.h View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/mediasession/mediaartwork.html View 1 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/mediasession/mediaartwork-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
A third_party/WebKit/LayoutTests/media/mediasession/mediaimage.html View 1 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/media/mediasession/mediaimage-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html View 1 1 chunk +8 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/mediasession/media/mediasession/mediaartwork-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/mediasession/media/mediasession/mediaimage-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/mediasession/MediaArtwork.h View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/modules/mediasession/MediaArtwork.cpp View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/modules/mediasession/MediaArtwork.idl View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/modules/mediasession/MediaImage.h View 3 chunks +10 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/modules/mediasession/MediaImage.cpp View 1 chunk +36 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/mediasession/MediaImage.idl View 1 chunk +3 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/modules/mediasession/MediaImageInit.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaMetadata.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaMetadata.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp View 4 chunks +21 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Zhiqiang Zhang (Slow)
4 years, 2 months ago (2016-10-06 16:09:03 UTC) #3
Tom Sepez
RS LGTM on renaming names.
4 years, 2 months ago (2016-10-06 18:31:47 UTC) #4
whywhat
lgtm
4 years, 2 months ago (2016-10-06 20:43:32 UTC) #5
clamy
Thanks! Lgtm.
4 years, 2 months ago (2016-10-07 11:16:28 UTC) #6
mlamouri (slow - plz ping)
lgtm rs lgtm
4 years, 2 months ago (2016-10-07 12:46:14 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2399023002 Patch 20001). Please resolve the dependency and ...
4 years, 2 months ago (2016-10-07 12:46:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394223002/60001
4 years, 2 months ago (2016-10-07 22:51:08 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-07 22:59:01 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 23:01:06 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/107c9084e019c286b8f8f4dbfc3130caa857e85a
Cr-Commit-Position: refs/heads/master@{#423999}

Powered by Google App Engine
This is Rietveld 408576698