Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2394203002: Fix GCMS::ListAccounts returning stale data on iOS. (Closed)

Created:
4 years, 2 months ago by bzanotti
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GCMS::ListAccounts returning stale data on iOS. Marking the listed accounts cache as stale in GCMS is done by listening to cookie changes (as this will catch any changes). However, cookie changes notifications are not available on iOS, causing the cache to be considered valid almost all the time. This CL correctly marks the cache as stale for the most ususal actions that will modify the listed accounts (AddAccount and LogOut). BUG=653546 Committed: https://crrev.com/987cf5a621eae6c77edf3774ba08b3d55bb3bd49 Cr-Commit-Position: refs/heads/master@{#423576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M components/signin/core/browser/gaia_cookie_manager_service.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bzanotti
Please take a look. Unrelated to the CL, but you and atwilson@ are still the ...
4 years, 2 months ago (2016-10-06 14:42:52 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
4 years, 2 months ago (2016-10-06 16:35:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394203002/1
4 years, 2 months ago (2016-10-06 16:37:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 17:38:47 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 17:40:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/987cf5a621eae6c77edf3774ba08b3d55bb3bd49
Cr-Commit-Position: refs/heads/master@{#423576}

Powered by Google App Engine
This is Rietveld 408576698