Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2394193002: [stubs] Fix some CodeStubAssembler macros and adds a bitcast in the ToObjectStub. (Closed)

Created:
4 years, 2 months ago by epertoso
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix some CodeStubAssembler macros and adds a bitcast in the ToObjectStub. This makes the MachineGraphVerifier happy with the stub. R=jarin@chromium.org BUG= Committed: https://crrev.com/a863620fbca431a3ff8b3671652d2d98ce1c9e4b Cr-Commit-Position: refs/heads/master@{#40154}

Patch Set 1 #

Patch Set 2 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M src/code-stub-assembler.cc View 1 2 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
epertoso
4 years, 2 months ago (2016-10-06 14:42:43 UTC) #2
Jarin
lgtm
4 years, 2 months ago (2016-10-11 07:55:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394193002/20001
4 years, 2 months ago (2016-10-11 07:57:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-11 08:23:17 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 08:23:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a863620fbca431a3ff8b3671652d2d98ce1c9e4b
Cr-Commit-Position: refs/heads/master@{#40154}

Powered by Google App Engine
This is Rietveld 408576698