Reland: Make clusterfuzz_archive include llvm-symbolizer and sancov.

scripts/slave/recipe_modules/archive/api.py

Index: scripts/slave/recipe_modules/archive/api.py
diff --git a/scripts/slave/recipe_modules/archive/api.py b/scripts/slave/recipe_modules/archive/api.py
index b451d1b9169b90d18a0bec72916984174de16e5a..0a8a7009dcc2e918193a0a72d5c5a8cf59cdc2f5 100644
--- a/scripts/slave/recipe_modules/archive/api.py
+++ b/scripts/slave/recipe_modules/archive/api.py
@@ -270,6 +270,18 @@ class ArchiveApi(recipe_api.RecipeApi):
     else:
       staging_dir = self.m.path.mkdtemp('chrome_staging')
 
+    llvm_tools_to_copy = ['llvm-symbolizer', 'sancov']
+    llvm_bin_dir = self.m.path['checkout'].join('third_party', 'llvm-build',
+                                                'Release+Asserts', 'bin')
+    ext = '.exe' if self.m.platform.is_win else ''
+
+    for tool in llvm_tools_to_copy:
+      tool_src = self.m.path.join(llvm_bin_dir, tool + ext)
+      tool_dst = self.m.path.join(build_dir, tool + ext)
+
+      if self.m.path.exists(tool_src) and not self.m.path.exists(tool_dst):

[Nico, 2016/10/07 19:29:32]

This relies on all bots that this runs on being clobber bots -- else,
eventually, when a new clang with new binaries is released, this won't overwrite
the old ones. Isn't there a "overwrite always" flag for file.copy?

[Oliver Chang, 2016/10/07 19:53:33]

Good point. What I needed was an ignore_errors flag, which shutil.copy accepts,
but the file recipe_module does not forward. 

I've removed the second check and made it catch an exception instead.

+        self.m.file.copy('Copy ' + tool, tool_src, tool_dst)
+
     # Build the list of files to archive.
     zip_file_list = [f for f in self.m.file.listdir('build_dir', build_dir)
                      if self._cf_should_package_file(f)]