Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2394163005: [Re-CL]Replace deprecated version of SetWithoutPathExpansion (Closed)

Created:
4 years, 2 months ago by dhna
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated version of SetWithoutPathExpansion BUG=650082 Committed: https://crrev.com/b25a9d3a8889276498314f9acd971349e732e199 Cr-Commit-Position: refs/heads/master@{#423842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M base/values.cc View 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
dhna
mark@ PTAL It's same CL as https://codereview.chromium.org/2401853002/ I fail to rebase my branch. So I ...
4 years, 2 months ago (2016-10-07 11:39:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394163005/1
4 years, 2 months ago (2016-10-07 11:40:16 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-07 11:40:18 UTC) #7
Mark Mentovai
LGTM
4 years, 2 months ago (2016-10-07 12:29:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394163005/1
4 years, 2 months ago (2016-10-07 12:49:20 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 12:53:55 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 12:55:46 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b25a9d3a8889276498314f9acd971349e732e199
Cr-Commit-Position: refs/heads/master@{#423842}

Powered by Google App Engine
This is Rietveld 408576698