chrome/browser/ui/views/extensions/media_galleries_dialog_views.h - Issue 2394123002: Views: Expose an on_closed callback via the MenuRunner constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/media_galleries_dialog_views.h

Issue 2394123002: Views: Expose an on_closed callback via the MenuRunner constructor. (Closed)

Patch Set: default arg Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/media_galleries_dialog_views.h

diff --git a/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h b/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h

index 29714146696d1c6842707ea3fdf2d44f3886cc5f..5ca9e9b257a1d314497f00181973ca5ec97ffae2 100644

--- a/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h

+++ b/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h

@@ -18,7 +18,6 @@

namespace views {

class Checkbox;

class LabelButton;

-class MenuModelAdapter;

class MenuRunner;

class Widget;

}

@@ -88,7 +87,7 @@ class MediaGalleriesDialogViews : public MediaGalleriesDialog,

// In unit tests, it may not.

bool ControllerHasWebContents() const;

- // Callback for MenuModelAdapter.

+ // Callback for MenuRunner.

void OnMenuClosed();

MediaGalleriesDialogController* controller_;

@@ -111,7 +110,6 @@ class MediaGalleriesDialogViews : public MediaGalleriesDialog,

// True if the user has pressed accept.

bool accepted_;

- std::unique_ptr<views::MenuModelAdapter> menu_model_adapter_;

std::unique_ptr<views::MenuRunner> context_menu_runner_;

DISALLOW_COPY_AND_ASSIGN(MediaGalleriesDialogViews);