Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc

Issue 2394123002: Views: Expose an on_closed callback via the MenuRunner constructor. (Closed)
Patch Set: default arg Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h" 5 #include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 #include "chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h" 11 #include "chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h"
12 #include "chrome/grit/generated_resources.h" 12 #include "chrome/grit/generated_resources.h"
13 #include "chrome/grit/locale_settings.h" 13 #include "chrome/grit/locale_settings.h"
14 #include "components/constrained_window/constrained_window_views.h" 14 #include "components/constrained_window/constrained_window_views.h"
15 #include "components/web_modal/web_contents_modal_dialog_manager.h" 15 #include "components/web_modal/web_contents_modal_dialog_manager.h"
16 #include "content/public/browser/web_contents.h" 16 #include "content/public/browser/web_contents.h"
17 #include "ui/base/l10n/l10n_util.h" 17 #include "ui/base/l10n/l10n_util.h"
18 #include "ui/native_theme/native_theme.h" 18 #include "ui/native_theme/native_theme.h"
19 #include "ui/views/border.h" 19 #include "ui/views/border.h"
20 #include "ui/views/controls/button/checkbox.h" 20 #include "ui/views/controls/button/checkbox.h"
21 #include "ui/views/controls/button/image_button.h" 21 #include "ui/views/controls/button/image_button.h"
22 #include "ui/views/controls/button/md_text_button.h" 22 #include "ui/views/controls/button/md_text_button.h"
23 #include "ui/views/controls/label.h" 23 #include "ui/views/controls/label.h"
24 #include "ui/views/controls/menu/menu_model_adapter.h"
25 #include "ui/views/controls/menu/menu_runner.h" 24 #include "ui/views/controls/menu/menu_runner.h"
26 #include "ui/views/controls/scroll_view.h" 25 #include "ui/views/controls/scroll_view.h"
27 #include "ui/views/controls/separator.h" 26 #include "ui/views/controls/separator.h"
28 #include "ui/views/layout/box_layout.h" 27 #include "ui/views/layout/box_layout.h"
29 #include "ui/views/layout/grid_layout.h" 28 #include "ui/views/layout/grid_layout.h"
30 #include "ui/views/layout/layout_constants.h" 29 #include "ui/views/layout/layout_constants.h"
31 #include "ui/views/view.h" 30 #include "ui/views/view.h"
32 #include "ui/views/widget/widget.h" 31 #include "ui/views/widget/widget.h"
33 #include "ui/views/window/dialog_client_view.h" 32 #include "ui/views/window/dialog_client_view.h"
34 33
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 if (iter->second->Contains(source)) { 298 if (iter->second->Contains(source)) {
300 ShowContextMenu(point, source_type, iter->first); 299 ShowContextMenu(point, source_type, iter->first);
301 return; 300 return;
302 } 301 }
303 } 302 }
304 } 303 }
305 304
306 void MediaGalleriesDialogViews::ShowContextMenu(const gfx::Point& point, 305 void MediaGalleriesDialogViews::ShowContextMenu(const gfx::Point& point,
307 ui::MenuSourceType source_type, 306 ui::MenuSourceType source_type,
308 MediaGalleryPrefId id) { 307 MediaGalleryPrefId id) {
309 menu_model_adapter_.reset(new views::MenuModelAdapter( 308 context_menu_runner_.reset(new views::MenuRunner(
310 controller_->GetContextMenu(id), 309 controller_->GetContextMenu(id),
310 views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::CONTEXT_MENU |
311 views::MenuRunner::ASYNC,
311 base::Bind(&MediaGalleriesDialogViews::OnMenuClosed, 312 base::Bind(&MediaGalleriesDialogViews::OnMenuClosed,
312 base::Unretained(this)))); 313 base::Unretained(this))));
313 314
314 context_menu_runner_.reset(new views::MenuRunner(
315 menu_model_adapter_->CreateMenu(), views::MenuRunner::HAS_MNEMONICS |
316 views::MenuRunner::CONTEXT_MENU |
317 views::MenuRunner::ASYNC));
318
319 context_menu_runner_->RunMenuAt(GetWidget(), NULL, 315 context_menu_runner_->RunMenuAt(GetWidget(), NULL,
320 gfx::Rect(point.x(), point.y(), 0, 0), 316 gfx::Rect(point.x(), point.y(), 0, 0),
321 views::MENU_ANCHOR_TOPLEFT, source_type); 317 views::MENU_ANCHOR_TOPLEFT, source_type);
322 } 318 }
323 319
324 bool MediaGalleriesDialogViews::ControllerHasWebContents() const { 320 bool MediaGalleriesDialogViews::ControllerHasWebContents() const {
325 return controller_->WebContents() != NULL; 321 return controller_->WebContents() != NULL;
326 } 322 }
327 323
328 void MediaGalleriesDialogViews::OnMenuClosed() { 324 void MediaGalleriesDialogViews::OnMenuClosed() {
329 menu_model_adapter_.reset();
330 context_menu_runner_.reset(); 325 context_menu_runner_.reset();
331 } 326 }
332 327
333 // MediaGalleriesDialogViewsController ----------------------------------------- 328 // MediaGalleriesDialogViewsController -----------------------------------------
334 329
335 // static 330 // static
336 MediaGalleriesDialog* MediaGalleriesDialog::Create( 331 MediaGalleriesDialog* MediaGalleriesDialog::Create(
337 MediaGalleriesDialogController* controller) { 332 MediaGalleriesDialogController* controller) {
338 return new MediaGalleriesDialogViews(controller); 333 return new MediaGalleriesDialogViews(controller);
339 } 334 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/extensions/media_galleries_dialog_views.h ('k') | chrome/browser/ui/views/frame/browser_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698