Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2394113002: fix 'GrClip::quickContains was hidden' warning in GrNoClip (Closed)

Created:
4 years, 2 months ago by lsalzman1
Modified:
4 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix 'GrClip::quickContains was hidden' warning in GrNoClip BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394113002 Committed: https://skia.googlesource.com/skia/+/9d2b0fea05a0d33a87027d486a3db4b5bba46bd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/gpu/GrClip.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lsalzman1
In Firefox, we compile with warnings-as-errors and we also have -Woverloaded-virtual enabled with GCC. GrClip.h ...
4 years, 2 months ago (2016-10-06 04:12:16 UTC) #3
bsalomon
lgtm
4 years, 2 months ago (2016-10-10 22:15:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394113002/1
4 years, 2 months ago (2016-10-10 22:15:22 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 22:36:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9d2b0fea05a0d33a87027d486a3db4b5bba46bd0

Powered by Google App Engine
This is Rietveld 408576698