Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2394103002: Fix for the missing new keyword on an external factory call and updated expected test failures/e… (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 define(['dart_sdk', 'async_helper', 'unittest', 'require'], 5 define(['dart_sdk', 'async_helper', 'unittest', 'require'],
6 function(dart_sdk, async_helper, unittest, require) { 6 function(dart_sdk, async_helper, unittest, require) {
7 'use strict'; 7 'use strict';
8 8
9 async_helper = async_helper.async_helper; 9 async_helper = async_helper.async_helper;
10 10
11 dart_sdk._isolate_helper.startRootIsolate(function() {}, []); 11 dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
12 let html_config = unittest.html_config; 12 let html_config = unittest.html_config;
13 // Test attributes are a list of strings, or a string for a single 13 // Test attributes are a list of strings, or a string for a single
14 // attribute. Valid attributes are: 14 // attribute. Valid attributes are:
15 // 15 //
16 // 'skip' - don't run the test 16 // 'skip' - don't run the test
17 // 'fail' - test fails 17 // 'fail' - test fails
18 // 'timeout' - test times out 18 // 'timeout' - test times out
19 // 'slow' - use 5s timeout instead of default 2s. 19 // 'slow' - use 5s timeout instead of default 2s.
20 // 'helper' - not a test, used by other tests. 20 // 'helper' - not a test, used by other tests.
21 // 'unittest' - run separately as a unittest test. 21 // 'unittest' - run separately as a unittest test.
22 // 22 //
23 // Common combinations: 23 // Common combinations:
24 const fail = 'fail'; 24 const fail = 'fail';
25 const skip_fail = ['skip', 'fail']; 25 const skip_fail = ['skip', 'fail'];
26 const skip_timeout = ['skip', 'timeout']; 26 const skip_timeout = ['skip', 'timeout'];
27 27
28 // The number of expected unittest errors should be zero but unfortunately 28 // The number of expected unittest errors should be zero but unfortunately
29 // there are a lot of broken html unittests. 29 // there are a lot of broken html unittests.
30 let num_expected_unittest_fails = 3; 30 let num_expected_unittest_fails = 5;
31 let num_expected_unittest_errors = 2; 31 let num_expected_unittest_errors = 8;
32 32
33 // TODO(jmesserly): separate StrongModeError from other errors. 33 // TODO(jmesserly): separate StrongModeError from other errors.
34 let all_status = { 34 let all_status = {
35 'language': { 35 'language': {
36 'assert_with_type_test_or_cast_test': skip_fail, 36 'assert_with_type_test_or_cast_test': skip_fail,
37 'assertion_test': skip_fail, 37 'assertion_test': skip_fail,
38 'async_await_test_none_multi': 'unittest', 38 'async_await_test_none_multi': 'unittest',
39 'async_await_test_02_multi': 'unittest', 39 'async_await_test_02_multi': 'unittest',
40 'async_await_test_03_multi': skip_fail, // Flaky on travis (#634) 40 'async_await_test_03_multi': skip_fail, // Flaky on travis (#634)
41 'async_star_await_pauses_test': skip_fail, 41 'async_star_await_pauses_test': skip_fail,
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 'js_util_test': 'unittest', 488 'js_util_test': 'unittest',
489 'js_typed_interop_anonymous2_exp_test': 'unittest', 489 'js_typed_interop_anonymous2_exp_test': 'unittest',
490 'js_typed_interop_anonymous2_test': 'unittest', 490 'js_typed_interop_anonymous2_test': 'unittest',
491 'js_typed_interop_anonymous_exp_test': 'unittest', 491 'js_typed_interop_anonymous_exp_test': 'unittest',
492 'js_typed_interop_anonymous_test': 'unittest', 492 'js_typed_interop_anonymous_test': 'unittest',
493 'js_typed_interop_anonymous_unreachable_exp_test': 'unittest', 493 'js_typed_interop_anonymous_unreachable_exp_test': 'unittest',
494 'js_typed_interop_anonymous_unreachable_test': 'unittest', 494 'js_typed_interop_anonymous_unreachable_test': 'unittest',
495 'js_typed_interop_default_arg_test': 'unittest', 495 'js_typed_interop_default_arg_test': 'unittest',
496 'js_typed_interop_side_cast_exp_test': 'unittest', 496 'js_typed_interop_side_cast_exp_test': 'unittest',
497 'js_typed_interop_side_cast_test': 'unittest', 497 'js_typed_interop_side_cast_test': 'unittest',
498 'js_typed_interop_test': ['unittest', 'skip', 'fail'], 498 'js_typed_interop_test': 'unittest',
499 'keyboard_event_test': ['unittest', 'skip', 'fail'], 499 'keyboard_event_test': ['unittest', 'skip', 'fail'],
500 'localstorage_test': ['unittest', 'skip', 'fail'], 500 'localstorage_test': ['unittest', 'skip', 'fail'],
501 'location_test': ['unittest', 'skip', 'fail'], 501 'location_test': ['unittest', 'skip', 'fail'],
502 'mediasource_test': ['unittest', 'skip', 'fail'], 502 'mediasource_test': ['unittest', 'skip', 'fail'],
503 'media_stream_test': ['unittest', 'skip', 'fail'], 503 'media_stream_test': ['unittest', 'skip', 'fail'],
504 'messageevent_test': ['unittest', 'skip', 'fail'], 504 'messageevent_test': ['unittest', 'skip', 'fail'],
505 'mirrors_js_typed_interop_test': ['unittest', 'skip', 'fail'], 505 'mirrors_js_typed_interop_test': ['unittest', 'skip', 'fail'],
506 'mouse_event_test': ['unittest', 'skip', 'fail'], 506 'mouse_event_test': ['unittest', 'skip', 'fail'],
507 'mutationobserver_test': ['unittest', 'skip', 'fail'], 507 'mutationobserver_test': ['unittest', 'skip', 'fail'],
508 'native_gc_test': ['unittest', 'skip', 'fail'], 508 'native_gc_test': ['unittest', 'skip', 'fail'],
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 894
895 for (let action of unittest_tests) { 895 for (let action of unittest_tests) {
896 try { 896 try {
897 action(); 897 action();
898 } catch (e) { 898 } catch (e) {
899 console.error("Caught error tying to setup test:", e); 899 console.error("Caught error tying to setup test:", e);
900 } 900 }
901 } 901 }
902 }); 902 });
903 }); 903 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698