Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2394093002: Relanding changes to swarming isolate script and refactor of slave_utils (Closed)

Created:
4 years, 2 months ago by eyaich1
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Relanding changes to swarming isolate script and refactor of slave_utils Previous CL was missing return statements in GetMainRevision so all waterfalls that utilized this script were not working. BUG=chromium:633253 Committed: https://chromium.googlesource.com/chromium/tools/build/+/661c479e9dadfec6bf9c51a2b762eea23a5f5137

Patch Set 1 #

Patch Set 2 : Retraining expectations #

Patch Set 3 : Fixing long line #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -231 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 3 chunks +40 lines, -0 lines 1 comment Download
M scripts/slave/recipe_modules/test_utils/test_api.py View 2 chunks +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.py View 2 chunks +50 lines, -5 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json View 8 chunks +43 lines, -10 lines 0 comments Download
M scripts/slave/runtest.py View 1 2 5 chunks +16 lines, -152 lines 0 comments Download
M scripts/slave/slave_utils.py View 3 chunks +176 lines, -0 lines 0 comments Download
M scripts/slave/unittests/runtest_test.py View 4 chunks +4 lines, -54 lines 0 comments Download
M scripts/slave/unittests/slave_utils_test.py View 2 chunks +73 lines, -0 lines 0 comments Download
A scripts/slave/upload_perf_dashboard_results.py View 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
eyaich1
4 years, 2 months ago (2016-10-05 23:42:56 UTC) #2
Ken Russell (switch to Gerrit)
Rubber stamp LGTM In the future it would be better to upload the original CL ...
4 years, 2 months ago (2016-10-05 23:49:31 UTC) #3
eyaich1
Adding Pawel for owners approval since I think Dirk is OOO.
4 years, 2 months ago (2016-10-06 16:16:56 UTC) #5
Dirk Pranke
rs- lgtm.
4 years, 2 months ago (2016-10-06 16:22:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394093002/40001
4 years, 2 months ago (2016-10-06 16:28:54 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/build/+/661c479e9dadfec6bf9c51a2b762eea23a5f5137
4 years, 2 months ago (2016-10-06 16:36:21 UTC) #10
tandrii(chromium)
4 years, 2 months ago (2016-10-11 12:21:43 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/2394093002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/steps.py (right):

https://codereview.chromium.org/2394093002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:1110: print 'Info: No chart
json present'
This is now printed while simulation_test is run, polluting output. If you
actually want these printed, these should be output using annotations such as:
  step_result.presentation.step_text += "whatever you want to print"

Powered by Google App Engine
This is Rietveld 408576698