Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: ui/native_theme/native_theme_dark_aura.cc

Issue 2394083002: Fix label colors for dark native themes (incognito, shelf). (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/native_theme/native_theme_dark_aura.cc
diff --git a/ui/native_theme/native_theme_dark_aura.cc b/ui/native_theme/native_theme_dark_aura.cc
index d0d92739e5e7bd06a00192d907e16c64d116fb9b..f40f64c654bd48061b9941c4b791d450a093a2c8 100644
--- a/ui/native_theme/native_theme_dark_aura.cc
+++ b/ui/native_theme/native_theme_dark_aura.cc
@@ -31,6 +31,12 @@ SkColor NativeThemeDarkAura::GetSystemColor(ColorId color_id) const {
SkColorSetA(kResultsTableText, 0x80);
switch (color_id) {
+ // Window
tdanderson 2016/10/06 14:05:05 Comparing this change to the CL where the regressi
Evan Stade 2016/10/06 15:35:46 we used to have a label background color for dark
+ case kColorId_WindowBackground:
+ case kColorId_DialogBackground:
+ case kColorId_BubbleBackground:
+ return SK_ColorBLACK;
+
// Button
case kColorId_ButtonEnabledColor:
return kButtonEnabledColor;
@@ -91,9 +97,6 @@ SkColor NativeThemeDarkAura::GetSystemColor(ColorId color_id) const {
return NativeThemeAura::GetSystemColor(color_id);
// Any other color is not defined and shouldn't be used in a dark theme.
- case kColorId_WindowBackground:
- case kColorId_DialogBackground:
- case kColorId_BubbleBackground:
case kColorId_UnfocusedBorderColor:
case kColorId_ButtonDisabledColor:
case kColorId_ButtonHoverColor:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698