Issue 2394023003: Move out OnceCallback and RepeatingCallback from internal namespace

Issue 2394023003: Move out OnceCallback and RepeatingCallback from internal namespace (Closed)

Created:
4 years, 2 months ago by tzik

Modified:
4 years, 2 months ago

Reviewers:
dcheng

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move out OnceCallback and RepeatingCallback from internal namespace BUG=554299 Committed: https://crrev.com/07dbcfdc2c0522f38e013afa6e8f761b09d3a515 Cr-Commit-Position: refs/heads/master@{#424694}

Patch Set 1 #

Patch Set 2 : rebase #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -16 lines)			Patch
M	base/bind.h	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	base/bind_unittest.cc	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	base/callback_forward.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 23 (18 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tzik

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

4 years, 2 months ago (2016-10-06 13:05:11 UTC) #1

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394023003/1

4 years, 2 months ago (2016-10-06 13:05:21 UTC) #2

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

tzik

Description was changed from ========== Move out OnceCallback and RepeatingCallback from internal namespace ========== to ...

4 years, 2 months ago (2016-10-06 13:06:25 UTC) #3

Description was changed from

==========
Move out OnceCallback and RepeatingCallback from internal namespace
==========

to

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: PSA
==========

tzik

Description was changed from ========== Move out OnceCallback and RepeatingCallback from internal namespace TODO: PSA ...

4 years, 2 months ago (2016-10-06 13:07:27 UTC) #4

Description was changed from

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: PSA
==========

to

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: PSA

BUG=554299
==========

tzik

Description was changed from ========== Move out OnceCallback and RepeatingCallback from internal namespace TODO: PSA ...

4 years, 2 months ago (2016-10-06 13:28:15 UTC) #5

Description was changed from

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: PSA

BUG=554299
==========

to

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: PSA, more tests in bind_unittest.cc

BUG=554299
==========

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-06 14:58:42 UTC) #6

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 2 months ago (2016-10-06 14:58:42 UTC) #7

Dry run: This issue passed the CQ dry run.

tzik

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

4 years, 2 months ago (2016-10-12 06:01:35 UTC) #8

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

tzik

Description was changed from ========== Move out OnceCallback and RepeatingCallback from internal namespace TODO: PSA, ...

4 years, 2 months ago (2016-10-12 06:01:45 UTC) #9

Description was changed from

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: PSA, more tests in bind_unittest.cc

BUG=554299
==========

to

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: PSA

BUG=554299
==========

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394023003/20001

4 years, 2 months ago (2016-10-12 06:01:49 UTC) #10

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

tzik

Description was changed from ========== Move out OnceCallback and RepeatingCallback from internal namespace TODO: PSA ...

4 years, 2 months ago (2016-10-12 06:29:36 UTC) #11

Description was changed from

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: PSA

BUG=554299
==========

to

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: Publish a PSA

BUG=554299
==========

tzik

Description was changed from ========== Move out OnceCallback and RepeatingCallback from internal namespace TODO: Publish ...

4 years, 2 months ago (2016-10-12 06:54:30 UTC) #12

Description was changed from

==========
Move out OnceCallback and RepeatingCallback from internal namespace

TODO: Publish a PSA

BUG=554299
==========

to

==========
Move out OnceCallback and RepeatingCallback from internal namespace

BUG=554299
==========

tzik

tzik@chromium.org changed reviewers: + dcheng@chromium.org

4 years, 2 months ago (2016-10-12 06:54:30 UTC) #13

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

tzik

PTAL

4 years, 2 months ago (2016-10-12 06:54:38 UTC) #14

PTAL

dcheng

LGTM

4 years, 2 months ago (2016-10-12 07:05:49 UTC) #15

LGTM

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-12 07:52:48 UTC) #16

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 2 months ago (2016-10-12 07:52:49 UTC) #17

Dry run: This issue passed the CQ dry run.

tzik

The CQ bit was checked by tzik@chromium.org

4 years, 2 months ago (2016-10-12 08:45:25 UTC) #18

The CQ bit was checked by tzik@chromium.org

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394023003/20001

4 years, 2 months ago (2016-10-12 08:45:38 UTC) #19

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

Description was changed from ========== Move out OnceCallback and RepeatingCallback from internal namespace BUG=554299 ========== ...

4 years, 2 months ago (2016-10-12 08:49:26 UTC) #20

Message was sent while issue was closed.

Description was changed from

==========
Move out OnceCallback and RepeatingCallback from internal namespace

BUG=554299
==========

to

==========
Move out OnceCallback and RepeatingCallback from internal namespace

BUG=554299
==========

commit-bot: I haz the power

Committed patchset #2 (id:20001)

4 years, 2 months ago (2016-10-12 08:49:27 UTC) #21

Message was sent while issue was closed.

Committed patchset #2 (id:20001)

commit-bot: I haz the power

Description was changed from ========== Move out OnceCallback and RepeatingCallback from internal namespace BUG=554299 ========== ...

4 years, 2 months ago (2016-10-12 08:51:27 UTC) #22

Message was sent while issue was closed.

Description was changed from

==========
Move out OnceCallback and RepeatingCallback from internal namespace

BUG=554299
==========

to

==========
Move out OnceCallback and RepeatingCallback from internal namespace

BUG=554299

Committed: https://crrev.com/07dbcfdc2c0522f38e013afa6e8f761b09d3a515
Cr-Commit-Position: refs/heads/master@{#424694}
==========

commit-bot: I haz the power

Patchset 2 (id:??) landed as https://crrev.com/07dbcfdc2c0522f38e013afa6e8f761b09d3a515 Cr-Commit-Position: refs/heads/master@{#424694}

4 years, 2 months ago (2016-10-12 08:51:28 UTC) #23

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/07dbcfdc2c0522f38e013afa6e8f761b09d3a515
Cr-Commit-Position: refs/heads/master@{#424694}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages