Issue 2393933002: Move the logic from SendAlgorithmInterface::RetransmissionDelay() into QuicSentPacketManager, becau…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2393933002: Move the logic from SendAlgorithmInterface::RetransmissionDelay() into QuicSentPacketManager, becau… (Closed)

Created:
4 years, 2 months ago by rjshade

Modified:
4 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move the logic from SendAlgorithmInterface::RetransmissionDelay() into QuicSentPacketManager, because it's identical for all send algorithms. No functional change, not flag protected. Merge internal change: 134467054 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -114 lines)			Patch
M	net/quic/chromium/quic_http_stream_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/quic/core/congestion_control/send_algorithm_interface.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	net/quic/core/congestion_control/tcp_cubic_sender_base.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/core/congestion_control/tcp_cubic_sender_base.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	net/quic/core/congestion_control/tcp_cubic_sender_bytes_test.cc	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	net/quic/core/quic_connection_test.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	net/quic/core/quic_sent_packet_manager.cc	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	net/quic/core/quic_sent_packet_manager_test.cc	View	6 chunks	+51 lines, -19 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2399473003 Patch 1

Dependent Patchsets:

Issue 2393943002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages