Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1899)

Unified Diff: content/shell/browser/shell_browser_main_parts.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_browser_main_parts.cc
diff --git a/content/shell/browser/shell_browser_main_parts.cc b/content/shell/browser/shell_browser_main_parts.cc
index 2b7726d0660d378d12dcbc28131c0cfb8cd60607..4928be34352047055ed9f12bba5611d75fe12932 100644
--- a/content/shell/browser/shell_browser_main_parts.cc
+++ b/content/shell/browser/shell_browser_main_parts.cc
@@ -18,6 +18,7 @@
#include "content/public/common/content_switches.h"
#include "content/public/common/main_function_params.h"
#include "content/public/common/url_constants.h"
+#include "content/shell/android/shell_descriptors.h"
#include "content/shell/browser/shell.h"
#include "content/shell/browser/shell_access_token_store.h"
#include "content/shell/browser/shell_browser_context.h"
@@ -37,6 +38,7 @@
#if defined(OS_ANDROID)
#include "base/message_loop/message_loop.h"
#include "components/crash/content/browser/crash_dump_manager_android.h"
+#include "components/crash/content/browser/crash_dump_observer_android.h"
#include "net/android/network_change_notifier_factory_android.h"
#include "net/base/network_change_notifier.h"
#endif
@@ -165,12 +167,15 @@ void ShellBrowserMainParts::InitializeMessageLoopContext() {
#if defined(OS_ANDROID)
int ShellBrowserMainParts::PreCreateThreads() {
+ breakpad::CrashDumpObserver::Create();
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableCrashReporter)) {
base::FilePath crash_dumps_dir =
base::CommandLine::ForCurrentProcess()->GetSwitchValuePath(
switches::kCrashDumpsDir);
- crash_dump_manager_.reset(new breakpad::CrashDumpManager(crash_dumps_dir));
+ breakpad::CrashDumpObserver::GetInstance()->RegisterClient(
+ base::MakeUnique<breakpad::CrashDumpManager>(
+ crash_dumps_dir, kAndroidMinidumpDescriptor));
}
return 0;
« no previous file with comments | « content/shell/browser/shell_browser_main_parts.h ('k') | content/shell/browser/shell_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698