Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chromecast/browser/cast_content_browser_client.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/cast_browser_process.cc ('k') | components/crash/content/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/cast_content_browser_client.cc
diff --git a/chromecast/browser/cast_content_browser_client.cc b/chromecast/browser/cast_content_browser_client.cc
index 7e21f0d417e4914f4415ea8c4428873309d53f7c..6f8cf77dfc476f152ba378d0925409034c44a761 100644
--- a/chromecast/browser/cast_content_browser_client.cc
+++ b/chromecast/browser/cast_content_browser_client.cc
@@ -468,19 +468,8 @@ void CastContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
kAndroidPakDescriptor,
base::GlobalDescriptors::GetInstance()->Get(kAndroidPakDescriptor),
base::GlobalDescriptors::GetInstance()->GetRegion(kAndroidPakDescriptor));
-
- if (breakpad::IsCrashReporterEnabled()) {
- base::File minidump_file(
- breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
- child_process_id));
- if (!minidump_file.IsValid()) {
- LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
- << "be disabled for this process.";
- } else {
- mappings->Transfer(kAndroidMinidumpDescriptor,
- base::ScopedFD(minidump_file.TakePlatformFile()));
- }
- }
+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+ child_process_id, mappings);
#else
int crash_signal_fd = GetCrashSignalFD(command_line);
if (crash_signal_fd >= 0) {
« no previous file with comments | « chromecast/browser/cast_browser_process.cc ('k') | components/crash/content/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698