Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: android_webview/browser/aw_browser_main_parts.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/BUILD.gn ('k') | android_webview/browser/aw_browser_terminator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_browser_main_parts.cc
diff --git a/android_webview/browser/aw_browser_main_parts.cc b/android_webview/browser/aw_browser_main_parts.cc
index bfb81d87d1e15995b2ed65d59d6d45ef15a12bc3..9ef01d0e9e5c7bba7c4efbe472a2fd21f43628d4 100644
--- a/android_webview/browser/aw_browser_main_parts.cc
+++ b/android_webview/browser/aw_browser_main_parts.cc
@@ -5,6 +5,7 @@
#include "android_webview/browser/aw_browser_main_parts.h"
#include "android_webview/browser/aw_browser_context.h"
+#include "android_webview/browser/aw_browser_terminator.h"
#include "android_webview/browser/aw_content_browser_client.h"
#include "android_webview/browser/aw_result_codes.h"
#include "android_webview/browser/deferred_gpu_command_service.h"
@@ -19,7 +20,7 @@
#include "base/files/file_path.h"
#include "base/i18n/rtl.h"
#include "base/path_service.h"
-#include "components/crash/content/browser/crash_micro_dump_manager_android.h"
+#include "components/crash/content/browser/crash_dump_observer_android.h"
#include "content/public/browser/android/synchronous_compositor.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
@@ -114,10 +115,12 @@ int AwBrowserMainParts::PreCreateThreads() {
base::android::MemoryPressureListenerAndroid::RegisterSystemCallback(
base::android::AttachCurrentThread());
DeferredGpuCommandService::SetInstance();
+ breakpad::CrashDumpObserver::Create();
if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSingleProcess)) {
// Create the renderers crash manager on the UI thread.
- breakpad::CrashMicroDumpManager::GetInstance();
+ breakpad::CrashDumpObserver::GetInstance()->RegisterClient(
+ base::MakeUnique<AwBrowserTerminator>());
}
return content::RESULT_CODE_NORMAL_EXIT;
« no previous file with comments | « android_webview/BUILD.gn ('k') | android_webview/browser/aw_browser_terminator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698