Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: content/shell/browser/shell_content_browser_client.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Review changes: remove refcounting, ability to unregister clients, move responsibility for posting to clients Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_content_browser_client.cc
diff --git a/content/shell/browser/shell_content_browser_client.cc b/content/shell/browser/shell_content_browser_client.cc
index 2b44625f151cf7d7cec3ed9b1aad65cb1f8d6d9c..4a2f09a42d78f557ae9edc5504da5d0a3cdebe18 100644
--- a/content/shell/browser/shell_content_browser_client.cc
+++ b/content/shell/browser/shell_content_browser_client.cc
@@ -343,18 +343,8 @@ void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
regions->insert(std::make_pair(
kShellPakDescriptor,
base::GlobalDescriptors::GetInstance()->GetRegion(kShellPakDescriptor)));
-
- if (breakpad::IsCrashReporterEnabled()) {
- base::File f(breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
- child_process_id));
- if (!f.IsValid()) {
- LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
- << "be disabled for this process.";
- } else {
- mappings->Transfer(kAndroidMinidumpDescriptor,
- base::ScopedFD(f.TakePlatformFile()));
- }
- }
+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+ child_process_id, mappings);
}
#elif defined(OS_POSIX) && !defined(OS_MACOSX)
void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess(

Powered by Google App Engine
This is Rietveld 408576698