Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4558)

Unified Diff: chromecast/browser/cast_content_browser_client.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Review changes: remove refcounting, ability to unregister clients, move responsibility for posting to clients Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_content_browser_client.cc
diff --git a/chromecast/browser/cast_content_browser_client.cc b/chromecast/browser/cast_content_browser_client.cc
index 7d9e4a3379d3e55d2b7943d3151788d7117efd92..7f1936e560e537264f47cf36ee355d97ce8c6f50 100644
--- a/chromecast/browser/cast_content_browser_client.cc
+++ b/chromecast/browser/cast_content_browser_client.cc
@@ -458,18 +458,8 @@ void CastContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
kAndroidPakDescriptor, base::GlobalDescriptors::GetInstance()->GetRegion(
kAndroidPakDescriptor)));
- if (breakpad::IsCrashReporterEnabled()) {
- base::File minidump_file(
- breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
- child_process_id));
- if (!minidump_file.IsValid()) {
- LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
- << "be disabled for this process.";
- } else {
- mappings->Transfer(kAndroidMinidumpDescriptor,
- base::ScopedFD(minidump_file.TakePlatformFile()));
- }
- }
+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+ child_process_id, mappings);
}
#else

Powered by Google App Engine
This is Rietveld 408576698