Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Review changes: remove refcounting, ability to unregister clients, move responsibility for posting to clients Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index b9b8d6659616103667c4bdf92d363b69f4f405ba..f4d2919cfbd00e6aa1810ab58a4b732003d87807 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2828,18 +2828,8 @@ void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
fd = ui::GetLocalePackFd(&(*regions)[kAndroidLocalePakDescriptor]);
mappings->Share(kAndroidLocalePakDescriptor, fd);
- if (breakpad::IsCrashReporterEnabled()) {
- base::File file =
- breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
- child_process_id);
- if (file.IsValid()) {
- mappings->Transfer(kAndroidMinidumpDescriptor,
- base::ScopedFD(file.TakePlatformFile()));
- } else {
- LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
- "be disabled for this process.";
- }
- }
+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+ child_process_id, mappings);
base::FilePath app_data_path;
PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path);

Powered by Google App Engine
This is Rietveld 408576698