Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Review changes: remove refcounting, ability to unregister clients, move responsibility for posting to clients Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index a6bb56546a7109084126a3105ee4849681f6040c..cfa61ab77a0f73ba8443f20a930cccdeb3f63cde 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -35,7 +35,7 @@
#include "base/path_service.h"
#include "components/autofill/content/browser/content_autofill_driver_factory.h"
#include "components/cdm/browser/cdm_message_filter_android.h"
-#include "components/crash/content/browser/crash_micro_dump_manager_android.h"
+#include "components/crash/content/browser/crash_dump_observer_android.h"
#include "components/navigation_interception/intercept_navigation_delegate.h"
#include "components/spellcheck/spellcheck_build_features.h"
#include "content/public/browser/browser_message_filter.h"
@@ -489,13 +489,8 @@ void AwContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
fd = ui::GetLocalePackFd(&(*regions)[kAndroidWebViewLocalePakDescriptor]);
mappings->Share(kAndroidWebViewLocalePakDescriptor, fd);
- base::ScopedFD crash_signal_file =
- breakpad::CrashMicroDumpManager::GetInstance()->CreateCrashInfoChannel(
- child_process_id);
- if (crash_signal_file.is_valid()) {
- mappings->Transfer(kAndroidWebViewCrashSignalDescriptor,
- std::move(crash_signal_file));
- }
+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+ child_process_id, mappings);
}
void AwContentBrowserClient::OverrideWebkitPrefs(

Powered by Google App Engine
This is Rietveld 408576698