Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2519)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: rebase; review changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index edadc181b79f064b4e61b5ddca3e0c6a640b945a..a082aa7a789b12ac02a8b5f1caae7781997c0ec3 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2781,18 +2781,8 @@ void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
fd = ui::GetLocalePackFd(&(*regions)[kAndroidLocalePakDescriptor]);
mappings->Share(kAndroidLocalePakDescriptor, fd);
- if (breakpad::IsCrashReporterEnabled()) {
- base::File file =
- breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
- child_process_id);
- if (file.IsValid()) {
- mappings->Transfer(kAndroidMinidumpDescriptor,
- base::ScopedFD(file.TakePlatformFile()));
- } else {
- LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
- "be disabled for this process.";
- }
- }
+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+ child_process_id, mappings);
base::FilePath app_data_path;
PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path);

Powered by Google App Engine
This is Rietveld 408576698