Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: rebase; review changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 021681d964a9b368f0af0098405ebb5cd9e640f8..3a5ae445f12edc7cadac17f2ae6fa2e81e237a6d 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -34,7 +34,7 @@
#include "base/memory/ptr_util.h"
#include "base/path_service.h"
#include "components/cdm/browser/cdm_message_filter_android.h"
-#include "components/crash/content/browser/crash_micro_dump_manager_android.h"
+#include "components/crash/content/browser/crash_dump_observer_android.h"
#include "components/navigation_interception/intercept_navigation_delegate.h"
#include "content/public/browser/browser_message_filter.h"
#include "content/public/browser/browser_thread.h"
@@ -485,13 +485,8 @@ void AwContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
fd = ui::GetLocalePackFd(&(*regions)[kAndroidWebViewLocalePakDescriptor]);
mappings->Share(kAndroidWebViewLocalePakDescriptor, fd);
- base::ScopedFD crash_signal_file =
- breakpad::CrashMicroDumpManager::GetInstance()->CreateCrashInfoChannel(
- child_process_id);
- if (crash_signal_file.is_valid()) {
- mappings->Transfer(kAndroidWebViewCrashSignalDescriptor,
- std::move(crash_signal_file));
- }
+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+ child_process_id, mappings);
}
void AwContentBrowserClient::OverrideWebkitPrefs(

Powered by Google App Engine
This is Rietveld 408576698