Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Side by Side Diff: chromecast/browser/cast_browser_main_parts.h

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: fix initialization in ShellBrowserMainParts Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_BROWSER_CAST_BROWSER_MAIN_PARTS_H_ 5 #ifndef CHROMECAST_BROWSER_CAST_BROWSER_MAIN_PARTS_H_
6 #define CHROMECAST_BROWSER_CAST_BROWSER_MAIN_PARTS_H_ 6 #define CHROMECAST_BROWSER_CAST_BROWSER_MAIN_PARTS_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "content/public/browser/browser_main_parts.h" 12 #include "content/public/browser/browser_main_parts.h"
13 #include "content/public/common/main_function_params.h" 13 #include "content/public/common/main_function_params.h"
14 14
15 namespace base { 15 namespace base {
16 class SingleThreadTaskRunner; 16 class SingleThreadTaskRunner;
17 class Thread; 17 class Thread;
18 } // namespace base 18 } // namespace base
19 19
20 #if defined(OS_ANDROID)
Bernhard Bauer 2016/10/14 10:41:01 Nit: in the interest of simplicity, you might want
Tobias Sargeant 2016/12/08 16:41:41 Done.
21 namespace breakpad {
22 class CrashDumpManager;
23 }
24 #endif
25
20 namespace net { 26 namespace net {
21 class NetLog; 27 class NetLog;
22 } 28 }
23 29
24 namespace chromecast { 30 namespace chromecast {
25 class CastMemoryPressureMonitor; 31 class CastMemoryPressureMonitor;
26 32
27 namespace media { 33 namespace media {
28 class MediaCapsImpl; 34 class MediaCapsImpl;
29 class MediaPipelineBackendManager; 35 class MediaPipelineBackendManager;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 // Tracks usage of media resource by e.g. CMA pipeline, CDM. 81 // Tracks usage of media resource by e.g. CMA pipeline, CDM.
76 media::MediaResourceTracker* media_resource_tracker_; 82 media::MediaResourceTracker* media_resource_tracker_;
77 83
78 // Tracks all media pipeline backends. 84 // Tracks all media pipeline backends.
79 std::unique_ptr<media::MediaPipelineBackendManager> 85 std::unique_ptr<media::MediaPipelineBackendManager>
80 media_pipeline_backend_manager_; 86 media_pipeline_backend_manager_;
81 87
82 std::unique_ptr<CastMemoryPressureMonitor> memory_pressure_monitor_; 88 std::unique_ptr<CastMemoryPressureMonitor> memory_pressure_monitor_;
83 #endif 89 #endif
84 90
91 #if defined(OS_ANDROID)
92 scoped_refptr<breakpad::CrashDumpManager> crash_dump_manager_;
93 #endif
94
85 DISALLOW_COPY_AND_ASSIGN(CastBrowserMainParts); 95 DISALLOW_COPY_AND_ASSIGN(CastBrowserMainParts);
86 }; 96 };
87 97
88 } // namespace shell 98 } // namespace shell
89 } // namespace chromecast 99 } // namespace chromecast
90 100
91 #endif // CHROMECAST_BROWSER_CAST_BROWSER_MAIN_PARTS_H_ 101 #endif // CHROMECAST_BROWSER_CAST_BROWSER_MAIN_PARTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698