Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: ui/views/widget/native_widget_mac_unittest.mm

Issue 2393843002: MacViews: Implement CloseNow() as just -[NSWindow close]. (Closed)
Patch Set: Selfnits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/native_widget_mac_unittest.mm
diff --git a/ui/views/widget/native_widget_mac_unittest.mm b/ui/views/widget/native_widget_mac_unittest.mm
index 0dec9ded50095c597488f9b4f621fe55f2e16cf5..6c9e042e23065d9e68357041020528bfd0ba97e4 100644
--- a/ui/views/widget/native_widget_mac_unittest.mm
+++ b/ui/views/widget/native_widget_mac_unittest.mm
@@ -1157,7 +1157,7 @@ class ParentCloseMonitor : public WidgetObserver {
// Upon a parent-triggered close, the NSWindow relationship will already be
// removed. The parent should still be open (children are always closed
karandeepb 2016/10/18 10:00:29 "the NSWindow relation will already be removed". U
tapted 2016/10/19 06:20:25 Done. And actually added a OnWidgetDestroyed() ove
// first), but not have a delegate (since it is being torn down).
- EXPECT_FALSE([child->GetNativeWindow() parentWindow]);
+ EXPECT_TRUE([child->GetNativeWindow() parentWindow]);
EXPECT_TRUE([parent_nswindow_ isVisible]);
EXPECT_FALSE([parent_nswindow_ delegate]);
« ui/views/widget/native_widget_mac.mm ('K') | « ui/views/widget/native_widget_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698