Issue 2393813003: Add BazelWorkspace and move BazelFileUriResolver to it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2393813003: Add BazelWorkspace and move BazelFileUriResolver to it. (Closed)

Created:
4 years, 2 months ago by scheglov

Modified:
4 years, 2 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add BazelWorkspace and move BazelFileUriResolver to it. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8a3d8eee6788a7daeedd69aff474ab1bebb67b07

Patch Set 1 #

Total comments: 1

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+295 lines, -77 lines)			Patch
M	pkg/analyzer/lib/file_system/file_system.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/bazel.dart	View	2 chunks	+131 lines, -30 lines	0 comments	Download
M	pkg/analyzer/test/generated/bazel_test.dart	View	3 chunks	+162 lines, -45 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm https://codereview.chromium.org/2393813003/diff/1/pkg/analyzer/test/generated/bazel_test.dart File pkg/analyzer/test/generated/bazel_test.dart (right): https://codereview.chromium.org/2393813003/diff/1/pkg/analyzer/test/generated/bazel_test.dart#newcode30 pkg/analyzer/test/generated/bazel_test.dart:30: String ppp(String path) { ?!? I know 'provider.convertPath' ...

4 years, 2 months ago (2016-10-05 22:01:12 UTC) #2

scheglov

4 years, 2 months ago (2016-10-06 01:08:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a3d8eee6788a7daeedd69aff474ab1bebb67b07 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages