Polish Safe Browsing Subresource filter infobar.

Polish Safe Browsing Subresource filter infobar.

1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text

BUG=609747
Committed: https://crrev.com/b4907cc5d602ff470740b2eb6344b517edecb7b9
Cr-Commit-Position: refs/heads/master@{#423715}

[melandory, 2016-10-05 08:25:12]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 08:25:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2016-10-05 09:16:20]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 09:16:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2016-10-05 09:17:25]

Description was changed from

==========
Fix disappeared button and add explanation text to Subresource filter infobar.

BUG=609747
==========

to

==========
Polish Subresource filter infobar.

1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text

BUG=609747
==========

[melandory, 2016-10-05 09:21:01]

Description was changed from

==========
Polish Subresource filter infobar.

1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text

BUG=609747
==========

to

==========
Polish Safe Browsing Subresource filter infobar.

1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text

BUG=609747
==========

[commit-bot: I haz the power, 2016-10-05 10:55:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 10:55:01]

Dry run: This issue passed the CQ dry run.

[melandory, 2016-10-05 12:00:16]

melandory@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[melandory, 2016-10-05 12:00:17]

PTAL, screenshot attached to the bug

[gone, 2016-10-05 18:05:26]

lgtm

https://chromiumcodereview.appspot.com/2393813002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterInfoBar.java
(right):

https://chromiumcodereview.appspot.com/2393813002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterInfoBar.java:11:
* After user proceed through Safe Browsing warning interstitials that are
displayed when the site
proceeds

https://chromiumcodereview.appspot.com/2393813002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterInfoBar.java:12:
* ahead contains deceptive embedded content, the infobar appears, explains the
feature and give
gives

https://chromiumcodereview.appspot.com/2393813002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterInfoBar.java:28:
mExplanationMessage = explanationMessage;
Can't you just grab the String resource from the java side?

R.string.filtered_deceptive_content_prompt_explanation

You don't seem to be changing the string in any way.

[melandory, 2016-10-06 21:32:32]

https://codereview.chromium.org/2393813002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterInfoBar.java
(right):

https://codereview.chromium.org/2393813002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterInfoBar.java:11:
* After user proceed through Safe Browsing warning interstitials that are
displayed when the site
On 2016/10/05 18:05:26, dfalcantara (slow) wrote:
> proceeds

Done.

https://codereview.chromium.org/2393813002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterInfoBar.java:12:
* ahead contains deceptive embedded content, the infobar appears, explains the
feature and give
On 2016/10/05 18:05:26, dfalcantara (slow) wrote:
> gives

Done.

[melandory, 2016-10-06 21:32:40]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2016-10-06 21:33:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 22:41:10]

Description was changed from

==========
Polish Safe Browsing Subresource filter infobar.

1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text

BUG=609747
==========

to

==========
Polish Safe Browsing Subresource filter infobar.

1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text

BUG=609747
==========

[commit-bot: I haz the power, 2016-10-06 22:41:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 22:42:58]

Description was changed from

==========
Polish Safe Browsing Subresource filter infobar.

1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text

BUG=609747
==========

to

==========
Polish Safe Browsing Subresource filter infobar.

1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text

BUG=609747

Committed: https://crrev.com/b4907cc5d602ff470740b2eb6344b517edecb7b9
Cr-Commit-Position: refs/heads/master@{#423715}
==========

[commit-bot: I haz the power, 2016-10-06 22:42:59]

Patchset 2 (id:??) landed as
https://crrev.com/b4907cc5d602ff470740b2eb6344b517edecb7b9
Cr-Commit-Position: refs/heads/master@{#423715}