Move ToInt conversions to the MacroAssembler for x64

Move ToInt conversions to the MacroAssembler for x64

+ Prevent truncating TaggedToI from bailing out.

(This is a port of r16464)

BUG=
R=titzer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16615

[titzer, 2013-09-05 14:03:37]

lgtm

lgtm

https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x6...
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x6...
src/x64/lithium-codegen-x64.cc:4712: __ jmp(done);
Maybe not in this CL, but I think we can get rid of open jump here if there is
no frame. Can you drop in a TODO to that effect, just to mark that that is a
possibility?

https://codereview.chromium.org/23938003/diff/3001/src/x64/macro-assembler-x6...
File src/x64/macro-assembler-x64.cc (right):

https://codereview.chromium.org/23938003/diff/3001/src/x64/macro-assembler-x6...
src/x64/macro-assembler-x64.cc:3064: // If input was positive, we are ok and
return 0, otherwise
"otherwise deoptimize" -> "otherwise goto conversion_failed"

[oliv, 2013-09-05 16:01:51]

hey, ptal

https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x6...
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x6...
src/x64/lithium-codegen-x64.cc:4712: __ jmp(done);
On 2013/09/05 14:03:37, titzer wrote:
> Maybe not in this CL, but I think we can get rid of open jump here if there is
> no frame. Can you drop in a TODO to that effect, just to mark that that is a
> possibility?

good idea. its only a minor change, so i added it here and also in ia32.

https://codereview.chromium.org/23938003/diff/3001/src/x64/macro-assembler-x6...
File src/x64/macro-assembler-x64.cc (right):

https://codereview.chromium.org/23938003/diff/3001/src/x64/macro-assembler-x6...
src/x64/macro-assembler-x64.cc:3064: // If input was positive, we are ok and
return 0, otherwise
On 2013/09/05 14:03:37, titzer wrote:
> "otherwise deoptimize" -> "otherwise goto conversion_failed"

Done.

[titzer, 2013-09-10 07:28:12]

On 2013/09/05 16:01:51, oliv wrote:
> hey, ptal
> 
>
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x6...
> File src/x64/lithium-codegen-x64.cc (right):
> 
>
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x6...
> src/x64/lithium-codegen-x64.cc:4712: __ jmp(done);
> On 2013/09/05 14:03:37, titzer wrote:
> > Maybe not in this CL, but I think we can get rid of open jump here if there
is
> > no frame. Can you drop in a TODO to that effect, just to mark that that is a
> > possibility?
> 
> good idea. its only a minor change, so i added it here and also in ia32.
> 
>
https://codereview.chromium.org/23938003/diff/3001/src/x64/macro-assembler-x6...
> File src/x64/macro-assembler-x64.cc (right):
> 
>
https://codereview.chromium.org/23938003/diff/3001/src/x64/macro-assembler-x6...
> src/x64/macro-assembler-x64.cc:3064: // If input was positive, we are ok and
> return 0, otherwise
> On 2013/09/05 14:03:37, titzer wrote:
> > "otherwise deoptimize" -> "otherwise goto conversion_failed"
> 
> Done.

Can you upload another patchset?

[titzer, 2013-09-10 10:50:31]

lgtm

[oliv, 2013-09-10 12:37:52]

Committed patchset #2 manually as r16615.