Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2393783003: Mark required dictionary members as required (Closed)

Created:
4 years, 2 months ago by Raymond Toy
Modified:
4 years, 2 months ago
Reviewers:
tkent, hongchan
CC:
blink-reviews, chromium-reviews, haraken, hongchan, Raymond Toy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark required dictionary members as required Update code to remove explicit tests for required members and update tests accordingly. BUG=651090 TEST=constructor/iirfilter.html Committed: https://crrev.com/ad65d1a7dc4dcbd4578752439edd441f7fa7e81e Cr-Commit-Position: refs/heads/master@{#424480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/iirfilter.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/IIRFilterOptions.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceOptions.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Raymond Toy
PTAL
4 years, 2 months ago (2016-10-06 00:39:18 UTC) #6
hongchan
lgtm
4 years, 2 months ago (2016-10-06 17:52:47 UTC) #7
Raymond Toy
tkent: PTAL as API owner A minor tweak to the IDL to mark required dictionary ...
4 years, 2 months ago (2016-10-07 15:46:00 UTC) #9
tkent
lgtm
4 years, 2 months ago (2016-10-11 13:53:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393783003/1
4 years, 2 months ago (2016-10-11 15:40:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 17:53:43 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:55:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad65d1a7dc4dcbd4578752439edd441f7fa7e81e
Cr-Commit-Position: refs/heads/master@{#424480}

Powered by Google App Engine
This is Rietveld 408576698