Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2393773002: Fix devtools unable to start a shared workers. (Closed)

Created:
4 years, 2 months ago by jam
Modified:
4 years, 2 months ago
Reviewers:
caseq
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, ntp-dev+reviews_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jam, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, darin-cc_chromium.org, kmadhusu+watch_chromium.org, Jered, pedrosimonetti+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix devtools unable to start a shared workers. This regressed in r419646 because it changed a check for the request's process being alive to instead check if the WebContents is alive. The latter isn't true for worker-initiated requests. Since URLDataManagerBackend's behavior now changed back to what it used to do, I've also updated the data sources that were modified in the same cl to bring back WebContents null checks. BUG=652937 Committed: https://crrev.com/f72ebb00ab29f5ed639d24dd24b44f4ea6201a42 Cr-Commit-Position: refs/heads/master@{#423205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M chrome/browser/search/iframe_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/app_launcher_page_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M content/public/browser/url_data_source.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jam
4 years, 2 months ago (2016-10-05 06:31:20 UTC) #7
caseq
lgtm and thanks a lot for a prompt fix!
4 years, 2 months ago (2016-10-05 17:01:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393773002/1
4 years, 2 months ago (2016-10-05 17:27:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 17:33:52 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 17:35:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f72ebb00ab29f5ed639d24dd24b44f4ea6201a42
Cr-Commit-Position: refs/heads/master@{#423205}

Powered by Google App Engine
This is Rietveld 408576698