Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

Issue 2393763002: [DevTools] Cleanup DOMExtension.js. (Closed)
Patch Set: review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 4 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
5 * Copyright (C) 2009 Joseph Pecoraro 5 * Copyright (C) 2009 Joseph Pecoraro
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 10 *
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 * @param {!WebInspector.DeferredDOMNode} deferredNode 130 * @param {!WebInspector.DeferredDOMNode} deferredNode
131 * @return {!Node} 131 * @return {!Node}
132 */ 132 */
133 WebInspector.DOMPresentationUtils.linkifyDeferredNodeReference = function(deferr edNode) 133 WebInspector.DOMPresentationUtils.linkifyDeferredNodeReference = function(deferr edNode)
134 { 134 {
135 var root = createElement("div"); 135 var root = createElement("div");
136 var shadowRoot = WebInspector.createShadowRootWithCoreStyles(root, "componen ts/domUtils.css"); 136 var shadowRoot = WebInspector.createShadowRootWithCoreStyles(root, "componen ts/domUtils.css");
137 var link = shadowRoot.createChild("div", "node-link"); 137 var link = shadowRoot.createChild("div", "node-link");
138 link.createChild("content"); 138 link.createChild("content");
139 link.addEventListener("click", deferredNode.resolve.bind(deferredNode, onDef erredNodeResolved), false); 139 link.addEventListener("click", deferredNode.resolve.bind(deferredNode, onDef erredNodeResolved), false);
140 link.addEventListener("mousedown", consumeEvent, false); 140 link.addEventListener("mousedown", (e) => e.consume(), false);
141 141
142 /** 142 /**
143 * @param {?WebInspector.DOMNode} node 143 * @param {?WebInspector.DOMNode} node
144 */ 144 */
145 function onDeferredNodeResolved(node) 145 function onDeferredNodeResolved(node)
146 { 146 {
147 WebInspector.Revealer.reveal(node); 147 WebInspector.Revealer.reveal(node);
148 } 148 }
149 149
150 return root; 150 return root;
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
660 /** 660 /**
661 * @override 661 * @override
662 * @param {!WebInspector.DOMNode} node 662 * @param {!WebInspector.DOMNode} node
663 * @return {?{title: string, color: string}} 663 * @return {?{title: string, color: string}}
664 */ 664 */
665 decorate: function(node) 665 decorate: function(node)
666 { 666 {
667 return { title: this._title, color: this._color }; 667 return { title: this._title, color: this._color };
668 } 668 }
669 } 669 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698