Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2393753003: Remove deprecated method LSOpenFSRef. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated method LSOpenFSRef. It has a drop-in replacement: +[NSWorkspace sharedWorkspace]. BUG=650790 Committed: https://crrev.com/df33482d72769ccc6da015156320bae80172532b Cr-Commit-Position: refs/heads/master@{#423322}

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M remoting/host/setup/daemon_controller_delegate_mac.mm View 1 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
erikchen
sergeyu: Please review. I manually tested that this correctly opens the preference pane by working ...
4 years, 2 months ago (2016-10-05 01:10:49 UTC) #3
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-05 22:39:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393753003/20001
4 years, 2 months ago (2016-10-05 22:40:47 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 22:47:38 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 22:49:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df33482d72769ccc6da015156320bae80172532b
Cr-Commit-Position: refs/heads/master@{#423322}

Powered by Google App Engine
This is Rietveld 408576698