Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Side by Side Diff: chrome/browser/resources/settings/date_time_page/date_time_page.html

Issue 2393703005: MD Settings: Date and Time page, part 1/3 (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
3 <link rel="import" href="/controls/settings_checkbox.html"> 3 <link rel="import" href="/controls/settings_checkbox.html">
4 <link rel="import" href="/settings_shared_css.html"> 4 <link rel="import" href="/settings_shared_css.html">
5 5
6 <dom-module id="settings-date-time-page"> 6 <dom-module id="settings-date-time-page">
7 <template> 7 <template>
8 <style include="settings-shared"></style> 8 <style include="settings-shared"></style>
9 <div class="settings-box first block"> 9 <div class="settings-box first">
10 <div disabled$="[[!pageVisibility.timeZoneSelector]]"> 10 <!-- TODO(michaelpg): Time zone dropdown menu. -->
dpapad 2016/10/06 18:01:14 Just FYI, when you get to this, let's use <select
michaelpg 2016/10/06 18:22:49 I assume this means it's also okay to use settings
11 $i18n{timeZone}
michaelpg 2016/10/06 03:50:09 didn't delete from settings_strings.grdp because i
12 </div>
13 <settings-checkbox pref="{{prefs.settings.clock.use_24hour_clock}}" 11 <settings-checkbox pref="{{prefs.settings.clock.use_24hour_clock}}"
14 label="$i18n{use24HourClock}"> 12 label="$i18n{use24HourClock}">
15 </settings-checkbox> 13 </settings-checkbox>
16 <div id="setAutomatically">$i18n{dateTimeSetAutomatically}</div>
17 </div> 14 </div>
15 <paper-checkbox class="settings-box continuation"
dpapad 2016/10/06 18:01:14 Is there a preference of hiding this checkbox with
michaelpg 2016/10/06 18:22:50 Yes, definitely: A <template is="dom-if"> introduc
16 id="timeZoneDetectionCheckbox"
17 hidden="[[hideTimeZoneDetection_]]"
18 on-change="onTimeZoneDetectionCheckboxChange_">
19 $i18n{timeZoneGeolocation}
20 </paper-checkbox>
18 </template> 21 </template>
19 <script src="date_time_page.js"></script> 22 <script src="date_time_page.js"></script>
20 </dom-module> 23 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698