Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2393703003: Mark APK downloads as dangerous on Android (Closed)

Created:
4 years, 2 months ago by Nathan Parker
Modified:
4 years, 2 months ago
Reviewers:
asanka, qinmin
CC:
arv+watch_chromium.org, chromium-reviews, vakh (use Gerrit instead)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark APK downloads as dangerous on Android BUG=652907 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a82b8f2fdf6f365cb38c8792ec67f420cd762db4 Cr-Commit-Position: refs/heads/master@{#423013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/resources/safe_browsing/download_file_types.asciipb View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Nathan Parker
If the new download manager does check safe browsing file types, this should cause it ...
4 years, 2 months ago (2016-10-04 23:07:33 UTC) #5
asanka
lgtm. I'm okay with showing a warning here.
4 years, 2 months ago (2016-10-04 23:56:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393703003/1
4 years, 2 months ago (2016-10-05 00:08:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 00:16:28 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 00:20:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a82b8f2fdf6f365cb38c8792ec67f420cd762db4
Cr-Commit-Position: refs/heads/master@{#423013}

Powered by Google App Engine
This is Rietveld 408576698