Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2393693002: Reformat comments in core/layout/line (Closed)

Created:
4 years, 2 months ago by eae
Modified:
4 years, 2 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reformat comments in core/layout/line BUG=563793 R=ikilpatrick@chromium.org Committed: https://crrev.com/6664f8e0a2e420d96444ba04b3c723341c1c17be Cr-Commit-Position: refs/heads/master@{#422975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+608 lines, -429 lines) Patch
M third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContext.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 34 chunks +112 lines, -86 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/EllipsisBox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/GlyphOverflow.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 14 chunks +42 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.h View 4 chunks +23 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 32 chunks +136 lines, -96 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineIterator.h View 19 chunks +73 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.h View 5 chunks +19 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 14 chunks +49 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LayoutTextInfo.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBoxList.cpp View 7 chunks +39 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBreaker.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBreaker.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineInfo.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineLayoutState.h View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.h View 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.cpp View 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 11 chunks +35 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/TrailingObjects.h View 2 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/TrailingObjects.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/WordMeasurement.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
eae
4 years, 2 months ago (2016-10-04 20:53:53 UTC) #1
ikilpatrick
lgtm \o/
4 years, 2 months ago (2016-10-04 20:59:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393693002/1
4 years, 2 months ago (2016-10-04 21:08:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 22:44:14 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:48:01 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6664f8e0a2e420d96444ba04b3c723341c1c17be
Cr-Commit-Position: refs/heads/master@{#422975}

Powered by Google App Engine
This is Rietveld 408576698