reflow comments in core/layout/compositing,core/observer

third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/compositing/CompositedLayerMapping.h"
 
 #include "core/frame/FrameView.h"
 #include "core/layout/LayoutBoxModelObject.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/api/LayoutViewItem.h"
@@ skipping 73 matching lines @@
 TEST_F(CompositedLayerMappingTest, TallLayerInterestRect) {
   setBodyInnerHTML(
       "<div id='target' style='width: 200px; height: 10000px; will-change: "
       "transform'></div>");
 
   document().view()->updateAllLifecyclePhases();
   Element* element = document().getElementById("target");
   PaintLayer* paintLayer =
       toLayoutBoxModelObject(element->layoutObject())->layer();
   ASSERT_TRUE(paintLayer->graphicsLayerBacking());
-  // Screen-space visible content rect is [8, 8, 200, 600]. Mapping back to local, adding 4000px in all directions, then
-  // clipping, yields this rect.
+  // Screen-space visible content rect is [8, 8, 200, 600]. Mapping back to
+  // local, adding 4000px in all directions, then clipping, yields this rect.
   EXPECT_RECT_EQ(IntRect(0, 0, 200, 4592),
                  recomputeInterestRect(paintLayer->graphicsLayerBacking()));
 }
 
 TEST_F(CompositedLayerMappingTest, TallLayerWholeDocumentInterestRect) {
   setBodyInnerHTML(
       "<div id='target' style='width: 200px; height: 10000px; will-change: "
       "transform'></div>");
 
   document().settings()->setMainFrameClipsContent(false);
@@ skipping 20 matching lines @@
       "200px;'></div>");
 
   document().view()->updateAllLifecyclePhases();
   document().view()->setScrollPosition(DoublePoint(-5000, 0),
                                        ProgrammaticScroll);
   document().view()->updateAllLifecyclePhases();
 
   PaintLayer* paintLayer = document().layoutViewItem().layer();
   ASSERT_TRUE(paintLayer->graphicsLayerBacking());
   ASSERT_TRUE(paintLayer->compositedLayerMapping());
-  // A scroll by -5000px is equivalent to a scroll by (10000 - 5000 - 800)px = 4200px in non-RTL mode. Expanding
-  // the resulting rect by 4000px in each direction yields this result.
+  // A scroll by -5000px is equivalent to a scroll by (10000 - 5000 - 800)px =
+  // 4200px in non-RTL mode. Expanding the resulting rect by 4000px in each
+  // direction yields this result.
   EXPECT_RECT_EQ(IntRect(200, 0, 8800, 600),
                  recomputeInterestRect(paintLayer->graphicsLayerBacking()));
 }
 
 TEST_F(CompositedLayerMappingTest, RotatedInterestRect) {
   setBodyInnerHTML(
       "<div id='target' style='width: 200px; height: 200px; will-change: "
       "transform; transform: rotateZ(45deg)'></div>");
 
   document().view()->updateAllLifecyclePhases();
   Element* element = document().getElementById("target");
   PaintLayer* paintLayer =
       toLayoutBoxModelObject(element->layoutObject())->layer();
   ASSERT_TRUE(!!paintLayer->graphicsLayerBacking());
   EXPECT_RECT_EQ(IntRect(0, 0, 200, 200),
                  recomputeInterestRect(paintLayer->graphicsLayerBacking()));
 }
 
 TEST_F(CompositedLayerMappingTest, RotatedInterestRectNear90Degrees) {
   setBodyInnerHTML(
       "<div id='target' style='width: 10000px; height: 200px; will-change: "
       "transform; transform: rotateY(89.9999deg)'></div>");
 
   document().view()->updateAllLifecyclePhases();
   Element* element = document().getElementById("target");
   PaintLayer* paintLayer =
       toLayoutBoxModelObject(element->layoutObject())->layer();
   ASSERT_TRUE(!!paintLayer->graphicsLayerBacking());
-  // Because the layer is rotated to almost 90 degrees, floating-point error leads to a reverse-projected rect that is much much larger
-  // than the original layer size in certain dimensions. In such cases, we often fall back to the 4000px interest rect padding amount.
+  // Because the layer is rotated to almost 90 degrees, floating-point error
+  // leads to a reverse-projected rect that is much much larger than the
+  // original layer size in certain dimensions. In such cases, we often fall
+  // back to the 4000px interest rect padding amount.
   EXPECT_RECT_EQ(IntRect(0, 0, 4000, 200),
                  recomputeInterestRect(paintLayer->graphicsLayerBacking()));
 }
 
 TEST_F(CompositedLayerMappingTest, 3D90DegRotatedTallInterestRect) {
-  // It's rotated 90 degrees about the X axis, which means its visual content rect is empty, and so the interest rect is the
-  // default (0, 0, 4000, 4000) intersected with the layer bounds.
+  // It's rotated 90 degrees about the X axis, which means its visual content
+  // rect is empty, and so the interest rect is the default (0, 0, 4000, 4000)
+  // intersected with the layer bounds.
   setBodyInnerHTML(
       "<div id='target' style='width: 200px; height: 10000px; will-change: "
       "transform; transform: rotateY(90deg)'></div>");
 
   document().view()->updateAllLifecyclePhases();
   Element* element = document().getElementById("target");
   PaintLayer* paintLayer =
       toLayoutBoxModelObject(element->layoutObject())->layer();
   ASSERT_TRUE(!!paintLayer->graphicsLayerBacking());
   EXPECT_RECT_EQ(IntRect(0, 0, 200, 4000),
@@ skipping 31 matching lines @@
 TEST_F(CompositedLayerMappingTest, WideLayerInterestRect) {
   setBodyInnerHTML(
       "<div id='target' style='width: 10000px; height: 200px; will-change: "
       "transform'></div>");
 
   document().view()->updateAllLifecyclePhases();
   Element* element = document().getElementById("target");
   PaintLayer* paintLayer =
       toLayoutBoxModelObject(element->layoutObject())->layer();
   ASSERT_TRUE(!!paintLayer->graphicsLayerBacking());
-  // Screen-space visible content rect is [8, 8, 800, 200] (the screen is 800x600).
-  // Mapping back to local, adding 4000px in all directions, then clipping, yields this rect.
+  // Screen-space visible content rect is [8, 8, 800, 200] (the screen is
+  // 800x600).  Mapping back to local, adding 4000px in all directions, then
+  // clipping, yields this rect.
   EXPECT_RECT_EQ(IntRect(0, 0, 4792, 200),
                  recomputeInterestRect(paintLayer->graphicsLayerBacking()));
 }
 
 TEST_F(CompositedLayerMappingTest, FixedPositionInterestRect) {
   setBodyInnerHTML(
       "<div id='target' style='width: 300px; height: 400px; will-change: "
       "transform; position: fixed; top: 100px; left: 200px;'></div>");
 
   document().view()->updateAllLifecyclePhases();
@@ skipping 117 matching lines @@
       shouldFlattenTransform(*compositedLayerMapping->scrollingLayer()));
   EXPECT_TRUE(shouldFlattenTransform(
       *compositedLayerMapping->scrollingContentsLayer()));
 }
 
 TEST_F(CompositedLayerMappingTest, InterestRectChangedEnoughToRepaintEmpty) {
   IntSize layerSize(1000, 1000);
   // Both empty means there is nothing to do.
   EXPECT_FALSE(
       interestRectChangedEnoughToRepaint(IntRect(), IntRect(), layerSize));
-  // Going from empty to non-empty means we must re-record because it could be the first frame after construction or Clear.
+  // Going from empty to non-empty means we must re-record because it could be
+  // the first frame after construction or Clear.
   EXPECT_TRUE(interestRectChangedEnoughToRepaint(IntRect(), IntRect(0, 0, 1, 1),
                                                  layerSize));
   // Going from non-empty to empty is not special-cased.
   EXPECT_FALSE(interestRectChangedEnoughToRepaint(IntRect(0, 0, 1, 1),
                                                   IntRect(), layerSize));
 }
 
 TEST_F(CompositedLayerMappingTest,
        InterestRectChangedEnoughToRepaintNotBigEnough) {
   IntSize layerSize(1000, 1000);
@@ skipping 75 matching lines @@
       "<div id='div' style='width: 100px; height: 10000px'>Text</div>");
 
   document().view()->updateAllLifecyclePhases();
   GraphicsLayer* rootScrollingLayer =
       document().layoutViewItem().layer()->graphicsLayerBackingForScrolling();
   EXPECT_RECT_EQ(IntRect(0, 0, 800, 4600),
                  previousInterestRect(rootScrollingLayer));
 
   document().view()->setScrollPosition(IntPoint(0, 300), ProgrammaticScroll);
   document().view()->updateAllLifecyclePhases();
-  // Still use the previous interest rect because the recomputed rect hasn't changed enough.
+  // Still use the previous interest rect because the recomputed rect hasn't
+  // changed enough.
   EXPECT_RECT_EQ(IntRect(0, 0, 800, 4900),
                  recomputeInterestRect(rootScrollingLayer));
   EXPECT_RECT_EQ(IntRect(0, 0, 800, 4600),
                  previousInterestRect(rootScrollingLayer));
 
   document().view()->setScrollPosition(IntPoint(0, 600), ProgrammaticScroll);
   document().view()->updateAllLifecyclePhases();
   // Use recomputed interest rect because it changed enough.
   EXPECT_RECT_EQ(IntRect(0, 0, 800, 5200),
                  recomputeInterestRect(rootScrollingLayer));
   EXPECT_RECT_EQ(IntRect(0, 0, 800, 5200),
                  previousInterestRect(rootScrollingLayer));
 
   document().view()->setScrollPosition(IntPoint(0, 5400), ProgrammaticScroll);
   document().view()->updateAllLifecyclePhases();
   EXPECT_RECT_EQ(IntRect(0, 1400, 800, 8600),
                  recomputeInterestRect(rootScrollingLayer));
   EXPECT_RECT_EQ(IntRect(0, 1400, 800, 8600),
                  previousInterestRect(rootScrollingLayer));
 
   document().view()->setScrollPosition(IntPoint(0, 9000), ProgrammaticScroll);
   document().view()->updateAllLifecyclePhases();
-  // Still use the previous interest rect because it contains the recomputed interest rect.
+  // Still use the previous interest rect because it contains the recomputed
+  // interest rect.
   EXPECT_RECT_EQ(IntRect(0, 5000, 800, 5000),
                  recomputeInterestRect(rootScrollingLayer));
   EXPECT_RECT_EQ(IntRect(0, 1400, 800, 8600),
                  previousInterestRect(rootScrollingLayer));
 
   document().view()->setScrollPosition(IntPoint(0, 2000), ProgrammaticScroll);
   // Use recomputed interest rect because it changed enough.
   document().view()->updateAllLifecyclePhases();
   EXPECT_RECT_EQ(IntRect(0, 0, 800, 6600),
                  recomputeInterestRect(rootScrollingLayer));
@@ skipping 39 matching lines @@
 
   document().view()->updateAllLifecyclePhases();
   Element* scroller = document().getElementById("scroller");
   GraphicsLayer* scrollingLayer =
       scroller->layoutBox()->layer()->graphicsLayerBackingForScrolling();
   EXPECT_RECT_EQ(IntRect(0, 0, 400, 4600),
                  previousInterestRect(scrollingLayer));
 
   scroller->setScrollTop(300);
   document().view()->updateAllLifecyclePhases();
-  // Still use the previous interest rect because the recomputed rect hasn't changed enough.
+  // Still use the previous interest rect because the recomputed rect hasn't
+  // changed enough.
   EXPECT_RECT_EQ(IntRect(0, 0, 400, 4900),
                  recomputeInterestRect(scrollingLayer));
   EXPECT_RECT_EQ(IntRect(0, 0, 400, 4600),
                  previousInterestRect(scrollingLayer));
 
   scroller->setScrollTop(600);
   document().view()->updateAllLifecyclePhases();
   // Use recomputed interest rect because it changed enough.
   EXPECT_RECT_EQ(IntRect(0, 0, 400, 5200),
                  recomputeInterestRect(scrollingLayer));
   EXPECT_RECT_EQ(IntRect(0, 0, 400, 5200),
                  previousInterestRect(scrollingLayer));
 
   scroller->setScrollTop(5400);
   document().view()->updateAllLifecyclePhases();
   EXPECT_RECT_EQ(IntRect(0, 1400, 400, 8600),
                  recomputeInterestRect(scrollingLayer));
   EXPECT_RECT_EQ(IntRect(0, 1400, 400, 8600),
                  previousInterestRect(scrollingLayer));
 
   scroller->setScrollTop(9000);
   document().view()->updateAllLifecyclePhases();
-  // Still use the previous interest rect because it contains the recomputed interest rect.
+  // Still use the previous interest rect because it contains the recomputed
+  // interest rect.
   EXPECT_RECT_EQ(IntRect(0, 5000, 400, 5000),
                  recomputeInterestRect(scrollingLayer));
   EXPECT_RECT_EQ(IntRect(0, 1400, 400, 8600),
                  previousInterestRect(scrollingLayer));
 
   scroller->setScrollTop(2000);
   // Use recomputed interest rect because it changed enough.
   document().view()->updateAllLifecyclePhases();
   EXPECT_RECT_EQ(IntRect(0, 0, 400, 6600),
                  recomputeInterestRect(scrollingLayer));
@@ skipping 16 matching lines @@
       "</div");
 
   document().view()->updateAllLifecyclePhases();
   Element* scroller = document().getElementById("scroller");
   GraphicsLayer* scrollingLayer =
       scroller->layoutBox()->layer()->graphicsLayerBackingForScrolling();
 
   scroller->setScrollTop(5400);
   document().view()->updateAllLifecyclePhases();
   scroller->setScrollTop(9400);
-  // The above code creates an interest rect bigger than the interest rect if recomputed now.
+  // The above code creates an interest rect bigger than the interest rect if
+  // recomputed now.
   document().view()->updateAllLifecyclePhases();
   EXPECT_RECT_EQ(IntRect(0, 5400, 400, 4600),
                  recomputeInterestRect(scrollingLayer));
   EXPECT_RECT_EQ(IntRect(0, 1400, 400, 8600),
                  previousInterestRect(scrollingLayer));
 
   // Paint invalidation and repaint should change previous paint interest rect.
   document().getElementById("content")->setTextContent("Change");
   document().view()->updateAllLifecyclePhases();
   EXPECT_RECT_EQ(IntRect(0, 5400, 400, 4600),
@@ skipping 19 matching lines @@
                 ->visualOverflowRect()
                 .size()
                 .height(),
             100);
 
   CompositedLayerMapping* groupedMapping = document()
                                                .getElementById("squashed")
                                                ->layoutBox()
                                                ->layer()
                                                ->groupedMapping();
-  // The squashing layer is at (-10000, 190, 10100, 100) in viewport coordinates.
-  // The following rect is at (-4000, 190, 4100, 100) in viewport coordinates.
+  // The squashing layer is at (-10000, 190, 10100, 100) in viewport
+  // coordinates.  The following rect is at (-4000, 190, 4100, 100) in viewport

[eae, 2016/10/05 19:53:00]

Breaking after coordinates. here and allowing the full following sentence on a
separate line is probably better.

[Nico, 2016/10/05 19:58:14]

Done.

+  // coordinates.
   EXPECT_RECT_EQ(IntRect(6000, 0, 4100, 100),
                  groupedMapping->computeInterestRect(
                      groupedMapping->squashingLayer(), IntRect()));
 }
 
 TEST_F(CompositedLayerMappingTest,
        InterestRectOfSquashingLayerWithAncestorClip) {
   setBodyInnerHTML(
       "<style>body { margin: 0; }</style>"
       "<div style='overflow: hidden; width: 400px; height: 400px'>"
       "  <div style='position: relative; backface-visibility: hidden'>"
       "    <div style='position: absolute; top: -500px; width: 200px; height: "
       "700px; backface-visibility: hidden'></div>"
-      // Above overflow:hidden div and two composited layers make the squashing layer a child of an ancestor clipping layer.
+      // Above overflow:hidden div and two composited layers make the squashing
+      // layer a child of an ancestor clipping layer.
       "    <div id='squashed' style='height: 1000px; width: 10000px; right: 0; "
       "position: absolute'></div>"
       "  </div>"
       "</div>");
 
   CompositedLayerMapping* groupedMapping = document()
                                                .getElementById("squashed")
                                                ->layoutBox()
                                                ->layer()
                                                ->groupedMapping();
@@ skipping 58 matching lines @@
   EXPECT_RECT_EQ(IntRect(0, 3500, 500, 4500),
                  recomputeInterestRect(frameDocument.view()
                                            ->layoutViewItem()
                                            .enclosingLayer()
                                            ->graphicsLayerBacking()));
 }
 
 TEST_F(CompositedLayerMappingTest, InterestRectOfIframeWithContentBoxOffset) {
   document().setBaseURLOverride(KURL(ParsedURLString, "http://test.com"));
   document().frame()->settings()->setPreferCompositingToLCDTextEnabled(true);
-  // Set a 10px border in order to have a contentBoxOffset for the iframe element.
+  // Set a 10px border in order to have a contentBoxOffset for the iframe
+  // element.
   setBodyInnerHTML(
       "<style>body { margin: 0; } #frame { border: 10px solid black; } "
       "::-webkit-scrollbar { display: none; }</style>"
       "<iframe id=frame src='http://test.com' width='500' height='500' "
       "frameBorder='0'>"
       "</iframe>");
 
   Document& frameDocument =
       setupChildIframe("frame",
                        "<style>body { margin: 0; } #target { width: 200px; "
                        "height: 8000px;}</style> <div id=target></div>");
 
   document().view()->updateAllLifecyclePhases();
 
-  // Scroll 3000 pixels down to bring the scrollable area to somewhere in the middle.
+  // Scroll 3000 pixels down to bring the scrollable area to somewhere in the
+  // middle.
   frameDocument.view()->setScrollPosition(DoublePoint(0.0, 3000.0),
                                           ProgrammaticScroll);
   document().view()->updateAllLifecyclePhases();
 
   ASSERT_TRUE(frameDocument.view()->layoutViewItem().hasLayer());
   // The width is 485 pixels due to the size of the scrollbar.
   EXPECT_RECT_EQ(IntRect(0, 0, 500, 7500),
                  recomputeInterestRect(frameDocument.view()
                                            ->layoutViewItem()
                                            .enclosingLayer()
@@ skipping 17 matching lines @@
       "<div id='spacer' style='height: 2000px'></div>");
 
   document().view()->updateAllLifecyclePhases();
 
   // The translucent fixed box should not be promoted.
   Element* element = document().getElementById("translucent");
   PaintLayer* paintLayer =
       toLayoutBoxModelObject(element->layoutObject())->layer();
   EXPECT_EQ(NotComposited, paintLayer->compositingState());
 
-  // The opaque fixed box should be promoted and be opaque so that text will be drawn
-  // with subpixel anti-aliasing.
+  // The opaque fixed box should be promoted and be opaque so that text will be
+  // drawn with subpixel anti-aliasing.
   element = document().getElementById("opaque");
   paintLayer = toLayoutBoxModelObject(element->layoutObject())->layer();
   EXPECT_EQ(PaintsIntoOwnBacking, paintLayer->compositingState());
   EXPECT_TRUE(paintLayer->graphicsLayerBacking()->contentsOpaque());
 
-  // The opaque fixed box with shadow should not be promoted because the layer will
-  // include the shadow which is not opaque.
+  // The opaque fixed box with shadow should not be promoted because the layer
+  // will include the shadow which is not opaque.
   element = document().getElementById("opaque-with-shadow");
   paintLayer = toLayoutBoxModelObject(element->layoutObject())->layer();
   EXPECT_EQ(NotComposited, paintLayer->compositingState());
 
   document().frame()->settings()->setPreferCompositingToLCDTextEnabled(
       preferCompositing);
 }
 
 TEST_F(CompositedLayerMappingTest,
        ScrollingContentsAndForegroundLayerPaintingPhase) {
@@ skipping 47 matching lines @@
       "<div id='container' style='overflow: scroll; width: 300px; height: "
       "300px; border-radius: 5px; background: white; will-change: transform;'>"
       "    <div style='background-color: blue; width: 2000px; height: "
       "2000px;'></div>"
       "</div>");
 
   PaintLayer* layer =
       toLayoutBlock(getLayoutObjectByElementId("container"))->layer();
   EXPECT_TRUE(layer->canPaintBackgroundOntoScrollingContentsLayer());
 
-  // We currently don't use composited scrolling when the container has a border-radius
-  // so even though we can paint the background onto the scrolling contents layer we
-  // don't have a scrolling contents layer to paint into in this case.
+  // We currently don't use composited scrolling when the container has a
+  // border-radius so even though we can paint the background onto the scrolling
+  // contents layer we don't have a scrolling contents layer to paint into in
+  // this case.
   CompositedLayerMapping* mapping = layer->compositedLayerMapping();
   EXPECT_FALSE(mapping->hasScrollingLayer());
   EXPECT_FALSE(mapping->backgroundPaintsOntoScrollingContentsLayer());
 }
 
 // Make sure that clipping layers are removed or their masking bit turned off
 // when they're an ancestor of the root scroller element.
 TEST_F(CompositedLayerMappingTest, RootScrollerAncestorsNotClipped) {
   NonThrowableExceptionState nonThrow;
 
@@ skipping 67 matching lines @@
 
   // Since there's no need to composite the clip and we prefer LCD text, the
   // mapping should create an ancestorClippingLayer.
   ASSERT_TRUE(mapping->scrollingLayer());
   ASSERT_TRUE(mapping->ancestorClippingLayer());
 
   // Since the clip has a transform it should be composited so there's no
   // need for an ancestor clipping layer.
   ASSERT_TRUE(mapping2->scrollingLayer());
 
-  // The third <div> should have a clipping layer since it's composited and clips
-  // composited children.
+  // The third <div> should have a clipping layer since it's composited and
+  // clips composited children.
   ASSERT_TRUE(mapping3->clippingLayer());
 
   // All scrolling and clipping layers should have masksToBounds set on them.
   {
     EXPECT_TRUE(mapping->scrollingLayer()->platformLayer()->masksToBounds());
     EXPECT_TRUE(
         mapping->ancestorClippingLayer()->platformLayer()->masksToBounds());
     EXPECT_TRUE(mapping2->scrollingLayer()->platformLayer()->masksToBounds());
     EXPECT_TRUE(mapping3->clippingLayer()->platformLayer()->masksToBounds());
   }
@@ skipping 45 matching lines @@
     document().view()->updateAllLifecyclePhases();
     ASSERT_EQ(document().documentElement(),
               rootScrollerController.globalRootScroller());
 
     EXPECT_TRUE(mapping3->clippingLayer());
     EXPECT_TRUE(mapping3->clippingLayer()->platformLayer()->masksToBounds());
   }
 }
 
 }  // namespace blink