Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: chrome/browser/android/preferences/pref_service_bridge_unittest.cc

Issue 2393673003: Support multiple locales string for accept language list (Closed)
Patch Set: rebase and fix presubmit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/android/preferences/pref_service_bridge.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/preferences/pref_service_bridge.h" 5 #include "chrome/browser/android/preferences/pref_service_bridge.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 11
12 // A test class for PrefServiceBridge class. 12 // A test class for PrefServiceBridge class.
13 class PrefServiceBridgeTest : public testing::Test { 13 class PrefServiceBridgeTest : public testing::Test {
14 public: 14 public:
15 std::string GetAcceptLanguages(std::string locale, 15 std::string GetAcceptLanguages(std::string locale,
16 std::string accept_languages) { 16 std::string accept_languages) {
17 PrefServiceBridge::PrependToAcceptLanguagesIfNecessary(locale, 17 PrefServiceBridge::PrependToAcceptLanguagesIfNecessary(locale,
18 &accept_languages); 18 &accept_languages);
19 return accept_languages; 19 return accept_languages;
20 } 20 }
21 }; 21 };
22 22
23 TEST_F(PrefServiceBridgeTest, PrependToAcceptLanguagesAsNecessary) { 23 TEST_F(PrefServiceBridgeTest, PrependToAcceptLanguagesAsNecessary) {
24 EXPECT_EQ("ms-MY,ms,en-US,en", GetAcceptLanguages("ms_MY", "en-US,en")); 24 EXPECT_EQ("ms-MY,ms,en-US,en", GetAcceptLanguages("ms_MY", "en-US,en"));
25 EXPECT_EQ("de-CH,de,zh-TW,zh,en-US,en",
26 GetAcceptLanguages("de_CH,zh_TW", "en-US,en"));
27 EXPECT_EQ("de-CH,de,zh-TW,zh,fr-FR,fr,en-US,en",
28 GetAcceptLanguages("de_CH,zh_TW,fr_FR", "en-US,en"));
25 29
30 // Make sure we do not prepend language code even when a language code already
31 // exists.
32 EXPECT_EQ("zh-TW,zh-CN,zh", GetAcceptLanguages("zh_TW", "zh-CN,zh"));
26 EXPECT_EQ("de-CH,de-DE,de,en-US,en", 33 EXPECT_EQ("de-CH,de-DE,de,en-US,en",
27 GetAcceptLanguages("de_CH", "de-DE,de,en-US,en")); 34 GetAcceptLanguages("de_CH", "de-DE,de,en-US,en"));
35 EXPECT_EQ("en-GB,de-DE,de,en-US,en",
36 GetAcceptLanguages("en_GB,de_DE", "en-US,en"));
28 37
29 // Make sure we do not prepend language code even when a language code is at 38 // Make sure a language code is only inserted after the last languageTag that
30 // the end. 39 // contains that language.
31 EXPECT_EQ("zh-TW,zh-CN,zh", GetAcceptLanguages("zh_TW", "zh-CN,zh")); 40 EXPECT_EQ("fr-CA,fr-FR,fr,en-US,en",
41 GetAcceptLanguages("fr_CA,fr_FR", "en-US,en"));
32 } 42 }
33 43
34 TEST_F(PrefServiceBridgeTest, 44 TEST_F(PrefServiceBridgeTest,
35 ShouldNotPrependToAcceptLanguagesWhenNotNecessary) { 45 ShouldNotPrependToAcceptLanguagesWhenNotNecessary) {
36 // Java has some deprecated two letter language code. For instance, "iw" is 46 // Java has some deprecated two letter language code. For instance, "iw" is
37 // an old code that needs to be replaced by "he" which is the new code for 47 // an old code that needs to be replaced by "he" which is the new code for
38 // Hebrew. 48 // Hebrew.
39 EXPECT_EQ("he-IL,he,en-US,en", 49 EXPECT_EQ("he-IL,he,en-US,en",
40 GetAcceptLanguages("iw_IL", "he-IL,he,en-US,en")); 50 GetAcceptLanguages("iw_IL", "he-IL,he,en-US,en"));
51 EXPECT_EQ("he-IL,he,fr-FR,fr,en-US,en",
52 GetAcceptLanguages("iw_IL,fr_FR", "en-US,en"));
41 53
42 // This logic should not affect cases where original accept language already 54 // This logic should not affect cases where original accept language already
43 // reflects the language code in the locale. 55 // reflects the language code in the locale.
44 EXPECT_EQ("en-US,en", GetAcceptLanguages("en_US", "en-US,en")); 56 EXPECT_EQ("en-US,en", GetAcceptLanguages("en_US", "en-US,en"));
45 EXPECT_EQ("zh-CN,zh", GetAcceptLanguages("zh_CN", "zh-CN,zh")); 57 EXPECT_EQ("zh-CN,zh", GetAcceptLanguages("zh_CN", "zh-CN,zh"));
58 EXPECT_EQ("ms-MY,ms,en-US,en", GetAcceptLanguages("ms_MY,en_US", "en-US,en"));
46 59
47 // "ms" is not expected. No replacement takes place. 60 // "ms" is not expected. No replacement takes place.
48 EXPECT_EQ("en-US,en", GetAcceptLanguages("ms", "en-US,en")); 61 EXPECT_EQ("en-US,en", GetAcceptLanguages("ms", "en-US,en"));
49 } 62 }
OLDNEW
« no previous file with comments | « chrome/browser/android/preferences/pref_service_bridge.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698