Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2393633002: Add test for getEntriesByType and getEntriesByName. (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
igrigorik, esprehn
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for getEntriesByType and getEntriesByName. This Cl adds the test case for the case sensitivity of getEntriesByType and getEntriesByName. BUG=chromium:651507 Committed: https://crrev.com/e47ceb37e280a3c2e04a66eb48d41251b6ae56e2 Cr-Commit-Position: refs/heads/master@{#422880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/misc/get-entries-case-sensitivities.html View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-04 17:46:55 UTC) #4
igrigorik
On 2016/10/04 17:46:55, dsinclair wrote: > PTAL. lgtm.
4 years, 2 months ago (2016-10-04 17:49:33 UTC) #5
esprehn
lgtm
4 years, 2 months ago (2016-10-04 19:04:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393633002/1
4 years, 2 months ago (2016-10-04 19:06:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 19:12:43 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 19:15:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e47ceb37e280a3c2e04a66eb48d41251b6ae56e2
Cr-Commit-Position: refs/heads/master@{#422880}

Powered by Google App Engine
This is Rietveld 408576698