media/base/android/video_decoder_job.cc - Issue 239363003: Fix an issue that audio and video may ran out of sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/video_decoder_job.cc

Issue 239363003: Fix an issue that audio and video may ran out of sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix the flaky test in previous patch Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/android/video_decoder_job.cc

diff --git a/media/base/android/video_decoder_job.cc b/media/base/android/video_decoder_job.cc

index 12ab4414e34f2ec1f863e1d99ed2ad2b887c8dbf..884bc6d3d0ba6247073c9adb355783cf90576a0e 100644

--- a/media/base/android/video_decoder_job.cc

+++ b/media/base/android/video_decoder_job.cc

@@ -63,9 +63,10 @@ void VideoDecoderJob::ReleaseOutputBuffer(

int output_buffer_index,

size_t size,

bool render_output,

+ base::TimeDelta current_presentation_timestamp,

const ReleaseOutputCompletionCallback& callback) {

video_codec_bridge_->ReleaseOutputBuffer(output_buffer_index, render_output);

- callback.Run(0u);

+ callback.Run(current_presentation_timestamp, current_presentation_timestamp);

}

bool VideoDecoderJob::ComputeTimeToRender() const {