Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: src/hydrogen.cc

Issue 23936007: To diagnose chromium bug 284577, some additional CHECKS. TODOs are (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed nit Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after
1817 } 1817 }
1818 } 1818 }
1819 1819
1820 if_nil.CaptureContinuation(continuation); 1820 if_nil.CaptureContinuation(continuation);
1821 } 1821 }
1822 1822
1823 1823
1824 HValue* HGraphBuilder::BuildCreateAllocationMemento(HValue* previous_object, 1824 HValue* HGraphBuilder::BuildCreateAllocationMemento(HValue* previous_object,
1825 int previous_object_size, 1825 int previous_object_size,
1826 HValue* alloc_site) { 1826 HValue* alloc_site) {
1827 ASSERT(alloc_site != NULL); 1827 // TODO(mvstanton): ASSERT altered to CHECK to diagnose chromium bug 284577
1828 CHECK(alloc_site != NULL);
1828 HInnerAllocatedObject* alloc_memento = Add<HInnerAllocatedObject>( 1829 HInnerAllocatedObject* alloc_memento = Add<HInnerAllocatedObject>(
1829 previous_object, previous_object_size); 1830 previous_object, previous_object_size);
1830 Handle<Map> alloc_memento_map( 1831 Handle<Map> alloc_memento_map(
1831 isolate()->heap()->allocation_memento_map()); 1832 isolate()->heap()->allocation_memento_map());
1832 AddStoreMapConstant(alloc_memento, alloc_memento_map); 1833 AddStoreMapConstant(alloc_memento, alloc_memento_map);
1833 HObjectAccess access = HObjectAccess::ForAllocationMementoSite(); 1834 HObjectAccess access = HObjectAccess::ForAllocationMementoSite();
1834 Add<HStoreNamedField>(alloc_memento, access, alloc_site); 1835 Add<HStoreNamedField>(alloc_memento, access, alloc_site);
1835 return alloc_memento; 1836 return alloc_memento;
1836 } 1837 }
1837 1838
(...skipping 7841 matching lines...) Expand 10 before | Expand all | Expand 10 after
9679 if (ShouldProduceTraceOutput()) { 9680 if (ShouldProduceTraceOutput()) {
9680 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9681 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9681 } 9682 }
9682 9683
9683 #ifdef DEBUG 9684 #ifdef DEBUG
9684 graph_->Verify(false); // No full verify. 9685 graph_->Verify(false); // No full verify.
9685 #endif 9686 #endif
9686 } 9687 }
9687 9688
9688 } } // namespace v8::internal 9689 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698