Source/core/platform/audio/DirectConvolver.cpp - Issue 23936006: Use wtf macros for audio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/audio/DirectConvolver.cpp

Issue 23936006: Use wtf macros for audio (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Include CPU.h Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/audio/DenormalDisabler.h ('k') | Source/core/platform/audio/VectorMath.cpp » ('j') | Source/core/platform/audio/VectorMath.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/audio/DirectConvolver.cpp

diff --git a/Source/core/platform/audio/DirectConvolver.cpp b/Source/core/platform/audio/DirectConvolver.cpp

index 030719f53c3c26dee63c506c6c914cc964a7be53..5b8e3a58a25c866614495a1ed35cf6a7863bdb23 100644

--- a/Source/core/platform/audio/DirectConvolver.cpp

+++ b/Source/core/platform/audio/DirectConvolver.cpp

@@ -37,6 +37,7 @@

#endif

#include "core/platform/audio/VectorMath.h"

+#include "wtf/CPU.h"

namespace WebCore {

@@ -90,11 +91,11 @@ void DirectConvolver::process(AudioFloatArray* convolutionKernel, const float* s

memcpy(inputP, sourceP, sizeof(float) * framesToProcess);

#if OS(MACOSX)

-#if defined(__ppc__) || defined(__i386__)

+#if defined(__ppc__) || CPU(X86)

Raymond Toy (Google) 2013/09/09 16:54:19 Might as well remove the __ppc__ here and below?

conv(inputP - kernelSize + 1, 1, kernelP + kernelSize - 1, -1, destP, 1, framesToProcess, kernelSize);

#else

vDSP_conv(inputP - kernelSize + 1, 1, kernelP + kernelSize - 1, -1, destP, 1, framesToProcess, kernelSize);

-#endif // defined(__ppc__) || defined(__i386__)

+#endif // defined(__ppc__) || CPU(X86)

#else

// FIXME: The macro can be further optimized to avoid pipeline stalls. One possibility is to maintain 4 separate sums and change the macro to CONVOLVE_FOUR_SAMPLES.

#define CONVOLVE_ONE_SAMPLE \

« no previous file with comments | « Source/core/platform/audio/DenormalDisabler.h ('k') | Source/core/platform/audio/VectorMath.cpp » ('j') | Source/core/platform/audio/VectorMath.cpp » ('J')