Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23936006: Use wtf macros for audio (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use the CPU() and COMPILER() macros for audio where it is applicable. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157502

Patch Set 1 #

Patch Set 2 : Use CPU() and COMPILER() macros #

Patch Set 3 : Include CPU.h #

Patch Set 4 : Include CPU.h #

Total comments: 2

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M Source/core/platform/audio/DenormalDisabler.h View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M Source/core/platform/audio/DirectConvolver.cpp View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/platform/audio/VectorMath.cpp View 1 2 3 4 5 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lgombos
Make the code more consistent and robust. For me the upside is to easily find ...
7 years, 3 months ago (2013-09-08 21:24:20 UTC) #1
abarth-chromium
I'm not sure crogers is working on this code anymore. We might need to find ...
7 years, 3 months ago (2013-09-08 22:44:14 UTC) #2
lgombos
Adding Kenneth to the reviewers list. Kenneth, what do you think ?
7 years, 3 months ago (2013-09-09 14:28:47 UTC) #3
Ken Russell (switch to Gerrit)
-crogers, +rtoy LGTM
7 years, 3 months ago (2013-09-09 16:45:34 UTC) #4
Raymond Toy (Google)
LGTM, with nits. Should the ppc stuff be removed in this patch? Ok if you ...
7 years, 3 months ago (2013-09-09 16:54:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23936006/22001
7 years, 3 months ago (2013-09-10 00:34:30 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 04:30:23 UTC) #7
Message was sent while issue was closed. 
Change committed as 157502

Powered by Google App Engine
This is Rietveld 408576698