Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2393583002:
Make the 'Advanced' button into an h2 for easier a11y navigation. (Closed)
|
Created:
4 years, 2 months ago by hcarmona Modified:
4 years, 2 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake the 'Advanced' button into an h2 for easier a11y navigation.
No UI change.
BUG=626878
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/1be31b3cc02699adb840bd1c1d4fcdbb3d3c9dec
Cr-Commit-Position: refs/heads/master@{#423346}
Patch Set 1 #
Total comments: 2
Patch Set 2 : font: inherit #Messages
Total messages: 19 (13 generated)
Description was changed from ========== Make the 'Advanced' button into an h2 for easier a11y navigation. No UI change. BUG=626878 ========== to ========== Make the 'Advanced' button into an h2 for easier a11y navigation. No UI change. BUG=626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hcarmona@chromium.org changed reviewers: + dbeam@chromium.org
PTAL
lgtm https://codereview.chromium.org/2393583002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_main/settings_main.html (right): https://codereview.chromium.org/2393583002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_main/settings_main.html:37: font-weight: inherit; does font: inherit; work? should we do this more globally in settings_shared_css?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
https://codereview.chromium.org/2393583002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_main/settings_main.html (right): https://codereview.chromium.org/2393583002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_main/settings_main.html:37: font-weight: inherit; On 2016/10/04 16:43:59, Dan Beam wrote: > does font: inherit; work? > > should we do this more globally in settings_shared_css? font: inherit works here. Updated. This is a special case because it's not styled like a heading, h2 is a11y only. So, I don't think we need to do this in a more global place.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hcarmona@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2393583002/#ps20001 (title: "font: inherit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make the 'Advanced' button into an h2 for easier a11y navigation. No UI change. BUG=626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Make the 'Advanced' button into an h2 for easier a11y navigation. No UI change. BUG=626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1be31b3cc02699adb840bd1c1d4fcdbb3d3c9dec Cr-Commit-Position: refs/heads/master@{#423346} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1be31b3cc02699adb840bd1c1d4fcdbb3d3c9dec Cr-Commit-Position: refs/heads/master@{#423346} |
