Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2393533002: Delete unneeded include of webrtc's httpportallocator.h. (Closed)

Created:
4 years, 2 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unneeded include of webrtc's httpportallocator.h. BUG= Committed: https://crrev.com/3c9cd35dffc94c3fa60081c000d4b23679037125 Cr-Commit-Position: refs/heads/master@{#422931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M remoting/protocol/ice_transport_channel.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
nisse-chromium (ooo August 14)
PTAL. HttpPortAllocator is dead code in webrtc.
4 years, 2 months ago (2016-10-04 12:44:41 UTC) #2
pthatcher2
lgtm Although I'm not an owner :).
4 years, 2 months ago (2016-10-04 15:44:04 UTC) #4
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-04 20:12:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393533002/1
4 years, 2 months ago (2016-10-04 20:26:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 21:17:46 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:19:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c9cd35dffc94c3fa60081c000d4b23679037125
Cr-Commit-Position: refs/heads/master@{#422931}

Powered by Google App Engine
This is Rietveld 408576698