Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 239353006: Fix bug in SampleApp's Tiling View (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix bug in SampleApp's Tiling View SampleApp was crashing when invoked as "SampleApp --slide Tiling" due to r14171 (split SkPictureRecorder out of SkPicture - https://codereview.chromium.org/214953003/) Committed: http://code.google.com/p/skia/source/detail?r=14214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M samplecode/SampleTiling.cpp View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 8 months ago (2014-04-15 21:26:51 UTC) #1
bungeman-skia
lgtm
6 years, 8 months ago (2014-04-15 21:38:42 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-15 21:39:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/239353006/1
6 years, 8 months ago (2014-04-15 21:39:42 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 23:00:58 UTC) #5
Message was sent while issue was closed.
Change committed as 14214

Powered by Google App Engine
This is Rietveld 408576698