Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h

Issue 2393513004: Convert app banners to use Mojo. (Closed)
Patch Set: Add TODO Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h
diff --git a/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h b/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h
index dc38d0a89acf6f1c94c20c1c1ab71ca1ae2d0ef0..49ab522a507d838ccde4ecc4e9b848a2a67eebe9 100644
--- a/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h
+++ b/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h
@@ -6,14 +6,11 @@
#define AppBannerPromptResult_h
#include "bindings/core/v8/ScriptWrappable.h"
-#include "public/platform/modules/app_banner/WebAppBannerPromptResult.h"
#include "wtf/Noncopyable.h"
#include "wtf/text/WTFString.h"
namespace blink {
-class ScriptPromiseResolver;
-
class AppBannerPromptResult final
: public GarbageCollectedFinalized<AppBannerPromptResult>,
public ScriptWrappable {
@@ -21,9 +18,10 @@ class AppBannerPromptResult final
WTF_MAKE_NONCOPYABLE(AppBannerPromptResult);
public:
- static AppBannerPromptResult* create(
- const AtomicString& platform,
- WebAppBannerPromptResult::Outcome outcome) {
+ enum class Outcome { Accepted, Dismissed };
+
+ static AppBannerPromptResult* create(const String& platform,
+ Outcome outcome) {
return new AppBannerPromptResult(platform, outcome);
}
@@ -35,11 +33,10 @@ class AppBannerPromptResult final
DEFINE_INLINE_VIRTUAL_TRACE() {}
private:
- AppBannerPromptResult(const AtomicString& platform,
- WebAppBannerPromptResult::Outcome);
+ AppBannerPromptResult(const String& platform, Outcome);
String m_platform;
- WebAppBannerPromptResult::Outcome m_outcome;
+ Outcome m_outcome;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698