third_party/WebKit/LayoutTests/app_banner/testrunner-resolve-crash.html - Issue 2393513004: Convert app banners to use Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/app_banner/testrunner-resolve-crash.html

Issue 2393513004: Convert app banners to use Mojo. (Closed)

Patch Set: Add TODO Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/app_banner/before-install-prompt-event-constructor.html ('k') | third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/app_banner/testrunner-resolve-crash.html

diff --git a/third_party/WebKit/LayoutTests/app_banner/testrunner-resolve-crash.html b/third_party/WebKit/LayoutTests/app_banner/testrunner-resolve-crash.html

index bea62b8a2d0efd87339608391add2e0a31d3f14d..b85ba315d6a72b3284105f89b0bd4f9c3c02b4e2 100644

--- a/third_party/WebKit/LayoutTests/app_banner/testrunner-resolve-crash.html

+++ b/third_party/WebKit/LayoutTests/app_banner/testrunner-resolve-crash.html

@@ -3,6 +3,6 @@

test(function() {

- testRunner.resolveBeforeInstallPromptPromise(0, 'foo');

+ testRunner.resolveBeforeInstallPromptPromise('foo');

}, 'Test that calling resolveBeforeInstallPromptPromise does not crash');

</script>